Skip to content

Conversation

@benjirewis
Copy link
Contributor

@benjirewis benjirewis commented May 11, 2021

CXX-2255

Upgrades Ubuntu 16.04 tasks to Ubuntu 18.04 tasks in Evergreen.

@benjirewis
Copy link
Contributor Author

benjirewis commented May 11, 2021

There are a number of build failures that are causing the ubuntu1804-debug-std-experimental tasks to fail. They all reference uses of scoped_bson_t. I was hoping someone might have some context on why that is.

Looks like it has to do with the overload defined for the scoped_bson_t constructor; can we just use the std library for stdx polyfills now that we've upgraded to Ubuntu 18.04?

@benjirewis benjirewis marked this pull request as ready for review May 11, 2021 20:40
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #795 (78e94c1) into master (a2c02e6) will decrease coverage by 7.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
- Coverage   92.75%   85.50%   -7.26%     
==========================================
  Files         368      377       +9     
  Lines       21020    21757     +737     
==========================================
- Hits        19498    18603     -895     
- Misses       1522     3154    +1632     
Impacted Files Coverage Δ
src/mongocxx/test/spec/change_stream.cpp 6.66% <0.00%> (-91.12%) ⬇️
src/mongocxx/options/private/transaction.hh 12.76% <0.00%> (-78.35%) ⬇️
src/mongocxx/options/transaction.cpp 21.21% <0.00%> (-69.70%) ⬇️
src/mongocxx/test/transactions.cpp 4.65% <0.00%> (-68.79%) ⬇️
src/mongocxx/test/change_streams.cpp 42.24% <0.00%> (-55.72%) ⬇️
src/mongocxx/exception/operation_exception.cpp 38.46% <0.00%> (-53.21%) ⬇️
src/mongocxx/test/spec/monitoring.hh 60.00% <0.00%> (-40.00%) ⬇️
src/mongocxx/options/index_view.cpp 47.61% <0.00%> (-38.10%) ⬇️
src/mongocxx/private/client_session.hh 60.95% <0.00%> (-30.97%) ⬇️
src/mongocxx/options/client_session.cpp 70.00% <0.00%> (-30.00%) ⬇️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c02e6...78e94c1. Read the comment docs.

@benjirewis
Copy link
Contributor Author

Discussed offline: reverted the debug-std-experimental task to Ubuntu 16.04 to avoid compilation errors on g++ 5.5 (the compiler on Ubuntu 18.04) with non-standard polyfills (like EXPERIMENTAL). Filed CXX-2260 (and added a TODO) to address these errors and upgrade debug-std-experimental to Ubuntu 18.04.

.mci.yml Outdated
- ubuntu1804-build
- name: uninstall_check

# TODO CXX-2260 Upgrade std::experimental tasks to Ubuntu 18.04 after bug fixes with g++ 5.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this variant also be changed to test against 4.4 instead of latest in the meantime?

mongodb_version: *version_44

IIRC otherwise versioned API tests against the latest server version published on Ubuntu 16.04 may not pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great point. Used version_44 and updated comment and display_name.

@benjirewis benjirewis requested a review from kevinAlbs May 12, 2021 18:44
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, module the nit on the comment.

.mci.yml Outdated
- name: uninstall_check

# TODO CXX-2260 Upgrade std::experimental tasks to use Ubuntu 18.04 and mongodb_latest
# after bug fixes with g++ 5.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that g++5.5 actually worked and it was something around g++7.3 and newer that gave us problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point. Made the comment refer generically to newer g++ versions.

@benjirewis benjirewis merged commit 908f0e6 into mongodb:master May 13, 2021
@benjirewis benjirewis deleted the ubuntu1804.2255 branch May 13, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants