-
Notifications
You must be signed in to change notification settings - Fork 548
CXX-2255 Upgrade to Ubuntu 18.04 for Evergreen tasks #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are a number of build failures that are causing the Looks like it has to do with the overload defined for the |
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
==========================================
- Coverage 92.75% 85.50% -7.26%
==========================================
Files 368 377 +9
Lines 21020 21757 +737
==========================================
- Hits 19498 18603 -895
- Misses 1522 3154 +1632
Continue to review full report at Codecov.
|
|
Discussed offline: reverted the |
.mci.yml
Outdated
| - ubuntu1804-build | ||
| - name: uninstall_check | ||
|
|
||
| # TODO CXX-2260 Upgrade std::experimental tasks to Ubuntu 18.04 after bug fixes with g++ 5.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this variant also be changed to test against 4.4 instead of latest in the meantime?
mongodb_version: *version_44
IIRC otherwise versioned API tests against the latest server version published on Ubuntu 16.04 may not pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah great point. Used version_44 and updated comment and display_name.
kevinAlbs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rcsanchez97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, module the nit on the comment.
.mci.yml
Outdated
| - name: uninstall_check | ||
|
|
||
| # TODO CXX-2260 Upgrade std::experimental tasks to use Ubuntu 18.04 and mongodb_latest | ||
| # after bug fixes with g++ 5.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that g++5.5 actually worked and it was something around g++7.3 and newer that gave us problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point. Made the comment refer generically to newer g++ versions.
CXX-2255
Upgrades Ubuntu 16.04 tasks to Ubuntu 18.04 tasks in Evergreen.