Skip to content

Conversation

@kevinAlbs
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #833 (8156166) into master (c805491) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   91.32%   91.33%           
=======================================
  Files         381      381           
  Lines       22097    22097           
=======================================
+ Hits        20181    20183    +2     
+ Misses       1916     1914    -2     
Impacted Files Coverage Δ
examples/mongocxx/connect.cpp 80.95% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c805491...8156166. Read the comment docs.

@kevinAlbs kevinAlbs changed the title CXX-2297 add connect.sh CXX-2297 add connect.sh and Atlas Serverless connectivity test Oct 1, 2021
@@ -0,0 +1,41 @@
#!/bin/bash
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motivation for moving this into a separate script file is to make it easier to run locally. I build in a directory named cmake-build and can run this locally as follows:

MONGOC_INSTALL_PREFIX=/Users/kevin.albertson/install/mongo-c-driver-1.18.0 \
MONGOCXX_INSTALL_PREFIX=/Users/kevin.albertson/install/mongo-cxx-driver-dev \
LIB_DIR="lib" \
BUILD_TYPE="Debug" \
BUILD_DIR=$(pwd)/cmake-build \
URI="mongodb://localhost:27017/?" \
    ./.evergreen/connect.sh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a place (even as an extended comment at the beginning of the script, but perhaps as a help screen?) where you can put a scrubbed version of this example? Sounds very useful!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done!

@kevinAlbs kevinAlbs marked this pull request as ready for review October 1, 2021 01:21
Copy link
Contributor

@chardan chardan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, and definitely useful! I am not a shell expert but it seems ok to me-- a little elaboration in-situ on the usage seems like a good idea, but I like that you've broken this out and don't want to add a bunch of mechanism to get in the way of it being available.

@@ -0,0 +1,41 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a place (even as an extended comment at the beginning of the script, but perhaps as a help screen?) where you can put a scrubbed version of this example? Sounds very useful!

@kevinAlbs kevinAlbs requested a review from chardan October 1, 2021 17:43
Copy link
Contributor

@chardan chardan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if more modifications are needed for other platforms, etc., thanks for breaking this out and giving everyone a useful head start! LGTM. +1.

connect.sh runs the connect example with a MongoDB URI.

Example usage:
MONGOC_INSTALL_PREFIX=/Users/kevin.albertson/install/mongo-c-driver-1.18.0 \\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you if you want to leave your name in here, or if it should be scrubbed. I am fine with it as-is.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as-is.

Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinAlbs kevinAlbs merged commit 08b5778 into mongodb:master Oct 4, 2021
@kevinAlbs kevinAlbs deleted the connect.2297 branch October 4, 2021 22:13
@kevinAlbs kevinAlbs restored the connect.2297 branch February 3, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants