Skip to content

Conversation

@kevinAlbs
Copy link
Collaborator

Summary

Resync the error messages in the types CSFLE test to mongodb/specifications@6a7158d to resolve test failures on mongocryptd 6.0.0-alpha. Do not pull in test changes to expectations made in SPEC-1768. Updating the test runner for the new which is still an open task for the C++ driver in CXX-2155

Background & Motivation

The badQueries test is not included in C++ driver tests due to CDRIVER-3387. Only the types test was resynced.

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #856 (4fa0404) into master (fa271cc) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   91.27%   91.23%   -0.04%     
==========================================
  Files         383      383              
  Lines       22614    22614              
==========================================
- Hits        20640    20631       -9     
- Misses       1974     1983       +9     
Impacted Files Coverage Δ
src/mongocxx/pool.cpp 60.78% <0.00%> (-9.81%) ⬇️
src/mongocxx/test_util/client_helpers.cpp 86.17% <0.00%> (-0.82%) ⬇️
src/mongocxx/test/spec/util.cpp 89.05% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa271cc...4fa0404. Read the comment docs.

@kevinAlbs kevinAlbs requested a review from rcsanchez97 April 13, 2022 01:02
@kevinAlbs kevinAlbs marked this pull request as ready for review April 13, 2022 01:02
Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit 34da38b into mongodb:master Apr 13, 2022
kevinAlbs added a commit that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants