PYTHON-5911 - Mark test.test_server_selection_in_window.TestProse.tes…#2905
Merged
Conversation
…t_load_balancing as flaky again
Contributor
There was a problem hiding this comment.
Pull request overview
Re-marks the server-selection “load balancing” prose test as flaky to reduce CI noise after prior fixes (PYTHON-3689) did not make it fully deterministic.
Changes:
- Re-adds the
@flaky(...)decorator toTestProse.test_load_balancingin both sync and async test suites. - Adds the corresponding
flakyimport in each file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_server_selection_in_window.py | Imports flaky and decorates test_load_balancing as flaky (PYTHON-5911) for CPython/Linux. |
| test/asynchronous/test_server_selection_in_window.py | Mirrors the sync change for the async test suite, keeping the two suites consistent. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t_load_balancing as flaky again
PYTHON-5911
Changes in this PR
The fixes in PYTHON-3689 did not make the test completely deterministic. Re-adds the
@flakydecorator to the test in question.Test Plan
Test change only.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer