Skip to content

PYTHON-5911 - Mark test.test_server_selection_in_window.TestProse.tes…#2905

Merged
NoahStapp merged 1 commit into
mongodb:masterfrom
NoahStapp:PYTHON-5911
Jun 30, 2026
Merged

PYTHON-5911 - Mark test.test_server_selection_in_window.TestProse.tes…#2905
NoahStapp merged 1 commit into
mongodb:masterfrom
NoahStapp:PYTHON-5911

Conversation

@NoahStapp

Copy link
Copy Markdown
Contributor

…t_load_balancing as flaky again

PYTHON-5911

Changes in this PR

The fixes in PYTHON-3689 did not make the test completely deterministic. Re-adds the @flaky decorator to the test in question.

Test Plan

Test change only.

Checklist

Checklist for Author

  • [ ] Did you update the changelog (if necessary)?
  • Is there test coverage?
  • [ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

Copilot AI review requested due to automatic review settings June 30, 2026 19:59
@NoahStapp NoahStapp requested a review from a team as a code owner June 30, 2026 19:59
@NoahStapp NoahStapp requested a review from blink1073 June 30, 2026 19:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-marks the server-selection “load balancing” prose test as flaky to reduce CI noise after prior fixes (PYTHON-3689) did not make it fully deterministic.

Changes:

  • Re-adds the @flaky(...) decorator to TestProse.test_load_balancing in both sync and async test suites.
  • Adds the corresponding flaky import in each file.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/test_server_selection_in_window.py Imports flaky and decorates test_load_balancing as flaky (PYTHON-5911) for CPython/Linux.
test/asynchronous/test_server_selection_in_window.py Mirrors the sync change for the async test suite, keeping the two suites consistent.

@blink1073 blink1073 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@NoahStapp NoahStapp merged commit bde775e into mongodb:master Jun 30, 2026
85 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants