Skip to content

Remove pending status from BSON Symbol test #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2020
Merged

Remove pending status from BSON Symbol test #2120

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49b3357
Fix shared protocol specs on jruby
Nov 3, 2020
8971492
Remove pending for issue that was resolvedin bson 4.11.0
Nov 3, 2020
55751bb
Add conditional behavior on jruby
Nov 3, 2020
ac2c14a
Only run the bson symbol test when the BSON gem supports that functio…
Nov 3, 2020
f4992ae
Revert change and rely on BSON fix
Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions spec/integration/bson_symbol_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@
end

it 'round-trips symbol values using the same byte buffer' do
if BSON::Environment.jruby?
pending 'https://jira.mongodb.org/browse/RUBY-2128'
if BSON::Environment.jruby? && BSON::VERSION < "4.11.0"
skip 'This test is only relevant to bson versions that increment ByteBuffer '\
'read and write positions separately in JRuby, as implemented in ' \
'bson version 4.11.0. For more information, see https://jira.mongodb.org/browse/RUBY-2128'
end

Hash.from_bson(hash.to_bson).should == hash
Expand Down