RUBY-1673 Document collection options #2588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilshweky
commented
Aug 5, 2022
| # merged over the existing read preference / write concern. | ||
| # Provides a new collection with either a new read preference, new read | ||
| # concern or new write concern merged over the existing read preference / | ||
| # read concern / write concern. |
Contributor
Author
There was a problem hiding this comment.
As per RUBY-3084, the CHANGEABLE_OPTIONS contains both read and read_concern. The read option corresponds to the read_preference options. Now, this method has only documented the ability to change the read preference and write concern, while allowing the changing of read preference, read concern, and write concern.
There are two options here:
- document that
withalso allows changing read concern, which is what's done here - change
withto not allow the changing of read concern as per RUBY-3084.
This PR implements the former. I can also move this snippet to its own PR if that would be better.
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I made the ticket before reading this PR, I see that you've done several of the changes listed there in this PR already.
alexbevi
reviewed
Aug 5, 2022
Contributor
Author
|
This is ready for review. |
neilshweky
commented
Aug 5, 2022
| end | ||
| end | ||
|
|
||
| context "when creating collection with view_on and pipeline" do |
p-mongo
approved these changes
Aug 9, 2022
comandeo
approved these changes
Aug 11, 2022
neilshweky
added a commit
that referenced
this pull request
Aug 15, 2022
* RUBY-1673 Document collection options * RUBY-1673 remove read_preference option * RUBY-1673 amend #with docs to include read_concern * RUBY-1673 add missing options * RUBY-1673 verify max and size options work * RUBY-1673 nitpick * RUBY-1673 alphabetize the options * RUBY-1673 fix mmap tests * RUBY-1673 fix mmap tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.