Start applying rubocop a bit more broadly#2997
Merged
jamis merged 1 commit intomongodb:masterfrom Mar 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR broadens RuboCop enforcement by removing the file-level # rubocop:todo all directive from Ruby source files that already comply with the current RuboCop configuration, helping reduce reliance on blanket lint suppressions.
Changes:
- Removed
# rubocop:todo allfrom a set oflib/mongo/**files that pass RuboCop without modification.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/mongo/srv.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/semaphore.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/protocol.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/options.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/operation/op_msg_base.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/operation/find/builder.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/monitoring/event/cmap.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/monitoring/event.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/grid.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/distinguishing_semaphore.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/dbref.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/crypt/kms/local.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/crypt/kms/kmip.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/crypt/kms/azure.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/collection/view/builder.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/auth/aws/credentials_cache.rb | Removes blanket RuboCop suppression now that the file passes linting. |
| lib/mongo/auth/aws/credentials.rb | Removes blanket RuboCop suppression now that the file passes linting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
comandeo-mongo
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added
rubocop:todo allto all of our existing files, when we added Rubocop, with the idea that we'd go back and gradually start using the linter more widely. This is a step in that direction, removingrubocop:todofrom files that don't actually need it (these all pass the linter check with no modifications needed).