Skip to content

Start applying rubocop a bit more broadly#2997

Merged
jamis merged 1 commit intomongodb:masterfrom
jamis:rubocop-simplify
Mar 12, 2026
Merged

Start applying rubocop a bit more broadly#2997
jamis merged 1 commit intomongodb:masterfrom
jamis:rubocop-simplify

Conversation

@jamis
Copy link
Copy Markdown
Contributor

@jamis jamis commented Mar 12, 2026

We added rubocop:todo all to all of our existing files, when we added Rubocop, with the idea that we'd go back and gradually start using the linter more widely. This is a step in that direction, removing rubocop:todo from files that don't actually need it (these all pass the linter check with no modifications needed).

@jamis jamis marked this pull request as ready for review March 12, 2026 16:22
@jamis jamis requested a review from a team as a code owner March 12, 2026 16:22
@jamis jamis requested review from comandeo-mongo and Copilot March 12, 2026 16:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR broadens RuboCop enforcement by removing the file-level # rubocop:todo all directive from Ruby source files that already comply with the current RuboCop configuration, helping reduce reliance on blanket lint suppressions.

Changes:

  • Removed # rubocop:todo all from a set of lib/mongo/** files that pass RuboCop without modification.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/mongo/srv.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/semaphore.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/protocol.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/options.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/operation/op_msg_base.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/operation/find/builder.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/monitoring/event/cmap.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/monitoring/event.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/grid.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/distinguishing_semaphore.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/dbref.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/crypt/kms/local.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/crypt/kms/kmip.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/crypt/kms/azure.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/collection/view/builder.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/auth/aws/credentials_cache.rb Removes blanket RuboCop suppression now that the file passes linting.
lib/mongo/auth/aws/credentials.rb Removes blanket RuboCop suppression now that the file passes linting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jamis jamis merged commit 62f2b6d into mongodb:master Mar 12, 2026
170 of 175 checks passed
@jamis jamis deleted the rubocop-simplify branch March 12, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants