RUBY-3783 Test deprioritized selection with tag sets#3017
Merged
comandeo-mongo merged 1 commit intomongodb:masterfrom Apr 13, 2026
Merged
RUBY-3783 Test deprioritized selection with tag sets#3017comandeo-mongo merged 1 commit intomongodb:masterfrom
comandeo-mongo merged 1 commit intomongodb:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds server selection spec test fixtures to validate behavior when a deprioritized server is the only one matching the configured tag sets, covering both replica set topologies with and without a primary. This helps ensure correct selection/fallback behavior across read preference modes when tag set filtering interacts with deprioritization.
Changes:
- Added new YAML fixtures for
ReplicaSetWithPrimarycoveringSecondary,SecondaryPreferred,PrimaryPreferred, andNearestwhen only a deprioritized server matches tag sets. - Added matching YAML fixtures for
ReplicaSetNoPrimaryfor the same read preference modes. - Included regression coverage notes for CDRIVER-6248 in applicable cases.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/spec_tests/data/server_selection/ReplicaSetWithPrimary/read/DeprioritizedSecondaryPreferredOnlyMatchingTags.yml | Tests SecondaryPreferred behavior with tag sets when only the deprioritized server matches. |
| spec/spec_tests/data/server_selection/ReplicaSetWithPrimary/read/DeprioritizedSecondaryOnlyMatchingTags.yml | Tests Secondary behavior with tag sets when only the deprioritized server matches. |
| spec/spec_tests/data/server_selection/ReplicaSetWithPrimary/read/DeprioritizedPrimaryPreferredOnlyMatchingTags.yml | Tests PrimaryPreferred behavior with tag sets when only the deprioritized server matches. |
| spec/spec_tests/data/server_selection/ReplicaSetWithPrimary/read/DeprioritizedNearestOnlyMatchingTags.yml | Tests Nearest behavior with tag sets when only the deprioritized server matches. |
| spec/spec_tests/data/server_selection/ReplicaSetNoPrimary/read/DeprioritizedSecondaryPreferredOnlyMatchingTags.yml | Tests SecondaryPreferred in no-primary topology when only the deprioritized server matches. |
| spec/spec_tests/data/server_selection/ReplicaSetNoPrimary/read/DeprioritizedSecondaryOnlyMatchingTags.yml | Tests Secondary in no-primary topology when only the deprioritized server matches. |
| spec/spec_tests/data/server_selection/ReplicaSetNoPrimary/read/DeprioritizedPrimaryPreferredOnlyMatchingTags.yml | Tests PrimaryPreferred in no-primary topology when only the deprioritized server matches. |
| spec/spec_tests/data/server_selection/ReplicaSetNoPrimary/read/DeprioritizedNearestOnlyMatchingTags.yml | Tests Nearest in no-primary topology when only the deprioritized server matches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
comandeo-mongo
changed the title
jamis
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.