RUBY-3220 Add databaseName property to command events#3031
Merged
comandeo-mongo merged 1 commit intomongodb:masterfrom Apr 30, 2026
Merged
RUBY-3220 Add databaseName property to command events#3031comandeo-mongo merged 1 commit intomongodb:masterfrom
comandeo-mongo merged 1 commit intomongodb:masterfrom
Conversation
Sync find.yml from the command-logging-and-monitoring spec to assert databaseName on commandSucceededEvent and commandFailedEvent. The events themselves already expose database_name; this update exercises the spec change in the unified test fixture.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the unified command monitoring spec test for find to align with the upstream command-logging-and-monitoring specification by asserting databaseName on command succeeded/failed events.
Changes:
- Bump unified spec
schemaVersioninfind.ymlfrom1.1to1.15. - Add
databaseName: *databaseNameexpectations tocommandSucceededEventandcommandFailedEvententries (includinggetMore).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamis
approved these changes
Apr 30, 2026
comandeo-mongo
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find.ymlfrom the command-logging-and-monitoring spec socommandSucceededEventandcommandFailedEventexpectations includedatabaseName. Schema bumped from 1.1 to 1.15.database_nameonCommandStarted,CommandSucceeded, andCommandFailed, and the unified runner already supports assertingdatabaseNameon any command event — this change exercises that path through the unified spec tests.