RUBY-530 sasl gssapi support for MRI #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estolfo
changed the title
Contributor
|
Other than the Travis errors and function signature warning as mentioned by Jason, LGTM |
|
overall lgtm. some minor nitpicks plus look into init and destruct sequences |
Contributor
Author
|
thanks so much for your review, @bjori and @gjmurakami-10gen |
ext/csasl/csasl.c
Outdated
There was a problem hiding this comment.
pedantic comment.. but this file didn't exit until now. You cannot claim copyright before 2014 :]
|
LGTM! well done. |
|
#464 proposes a fix for the gemfile conflict preventing this from passing. |
estolfo
force-pushed
the
RUBY-530-gssapi-mri
branch
from
b5dd5dc to
29e0932
Compare
estolfo
force-pushed
the
RUBY-530-gssapi-mri
branch
from
e3dafca to
3adffda
Compare
estolfo
force-pushed
the
RUBY-530-gssapi-mri
branch
from
3adffda to
058ff27
Compare
estolfo
added a commit
that referenced
this pull request
Sep 5, 2014
RUBY-530 sasl gssapi support for MRI
This was referenced Sep 11, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support kerberos authentication for JRuby.
This pull request adds a c extension that allows you to use Kerberos when on MRI.