Skip to content

RUBY-1078 Use default max message size when value is nil #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2016
Merged

RUBY-1078 Use default max message size when value is nil #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mongo/protocol/message.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def self.deserialize(io, max_message_size = MAX_MESSAGE_SIZE)

# Protection from potential DOS man-in-the-middle attacks. See
# DRIVERS-276.
if length > max_message_size
if length > (max_message_size || MAX_MESSAGE_SIZE)
raise Error::MaxMessageSize.new(max_message_size)
end

Expand Down
13 changes: 13 additions & 0 deletions spec/mongo/protocol/reply_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,19 @@
end
end

context 'when the max message size is nil' do

let(:reply) { described_class.deserialize(io, nil) }

let(:length) { Mongo::Protocol::Message::MAX_MESSAGE_SIZE + 1 }

it 'uses the default max message size for comparison' do
expect {
reply
}.to raise_error(Mongo::Error::MaxMessageSize)
end
end

describe 'response flags' do

context 'no flags' do
Expand Down