Skip to content

RUBY-1223 Ignore lastWrite when comparing server descriptions #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estolfo merged 1 commit into from
Jul 3, 2017
Merged

RUBY-1223 Ignore lastWrite when comparing server descriptions #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mongo/server/description.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class Description
# Fields to exclude when comparing two descriptions.
#
# @since 2.0.6
EXCLUDE_FOR_COMPARISON = [ LOCAL_TIME ].freeze
EXCLUDE_FOR_COMPARISON = [ LOCAL_TIME, LAST_WRITE ].freeze

# @return [ Address ] address The server's address.
attr_reader :address
Expand Down
6 changes: 5 additions & 1 deletion spec/mongo/server/description_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
'maxWireVersion' => 2,
'minWireVersion' => 0,
'localTime' => Time.now,
'lastWrite' => { 'lastWriteDate' => Time.now },
'ok' => 1
}
end
Expand Down Expand Up @@ -838,7 +839,10 @@
end

let(:other) do
described_class.new(address, replica.merge('localTime' => 1))
described_class.new(address, replica.merge(
'localTime' => 1,
'lastWrite' => { 'lastWriteDate' => 1 }
))
end

it 'excludes certain fields' do
Expand Down