tets: test mock generation works #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
example failing test without my fix |
gssbzn
commented
Mar 9, 2022
Comment on lines
+49
to
+52
| const ( | ||
| mongoCLI = "mongocli" | ||
| atlasCLI = "atlascli" | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
drive by these were being imported from the version package but only used here
gssbzn
commented
Mar 9, 2022
Comment on lines
+62
to
+65
| type ReleaseInformation struct { | ||
| Version string | ||
| PublishedAt time.Time | ||
| } |
Contributor
Author
There was a problem hiding this comment.
same as above, imported from version but only ever used here
gssbzn
commented
Mar 9, 2022
Comment on lines
-19
to
-23
| const ( | ||
| MongoCLI = "mongocli" | ||
| AtlasCLI = "atlascli" | ||
| owner = "mongodb" | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
moved closer to where needed
gssbzn
commented
Mar 9, 2022
| ) | ||
|
|
||
| //go:generate mockgen -destination=../mocks/mock_release_version.go -package=mocks github.com/mongodb/mongocli/internal/version VersionFinder | ||
| //go:generate mockgen -destination=../mocks/mock_release_version.go -package=mocks github.com/mongodb/mongocli/internal/latestrelease VersionFinder |
Contributor
Author
There was a problem hiding this comment.
fix to mock generation
gssbzn
commented
Mar 9, 2022
Comment on lines
-32
to
-35
| type ReleaseInformation struct { | ||
| Version string | ||
| PublishedAt time.Time | ||
| } |
Contributor
Author
There was a problem hiding this comment.
moved closer to where needed
gssbzn
commented
Mar 9, 2022
| @@ -0,0 +1,32 @@ | |||
| --- | |||
Contributor
Author
There was a problem hiding this comment.
inspired by the docs check
Contributor
Author
I had some good inspiration to base this work from :) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
the
make gen-mockscommand has been broken for a while, fixing it and adding a test to make sure it worksChecklist
make fmtand formatted my code