Skip to content

task: add dependency caching to docs check #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2022
Merged

task: add dependency caching to docs check #1031

merged 3 commits into from
Mar 9, 2022

Conversation

@gssbzn
Copy link
Contributor

@gssbzn gssbzn commented Mar 9, 2022 •
edited
Loading

Proposed changes

Spotted this as part of #1029, when we generate mocks or docs internally make download dependencies.

We can cache them as we do for make tests saving a couple of seconds here and there

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

@gssbzn gssbzn marked this pull request as ready for review March 9, 2022 15:10
@gssbzn gssbzn requested a review from a team March 9, 2022 15:10
andreaangiolillo
andreaangiolillo approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 1469135 into master Mar 9, 2022
@gssbzn gssbzn deleted the cache-dependencies branch March 9, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gssbzn @andreaangiolillo