-
Notifications
You must be signed in to change notification settings - Fork 107
CLOUDP-195050: Atlas Federated Authentication configuration #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b85d4a to
6d31ace
Compare
josvazg
reviewed
Sep 13, 2023
c5957fe to
795b2bd
Compare
Contributor
josvazg
reviewed
Sep 25, 2023
josvazg
reviewed
Sep 25, 2023
josvazg
reviewed
Sep 25, 2023
josvazg
reviewed
Sep 25, 2023
pkg/controller/atlasfederatedauth/atlasfederatedauth_controller.go
Outdated
Show resolved
Hide resolved
helderjs
requested changes
Sep 26, 2023
pkg/controller/atlasfederatedauth/atlasfederatedauth_controller.go
Outdated
Show resolved
Hide resolved
3 tasks
helderjs
approved these changes
Sep 27, 2023
Collaborator
helderjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
josvazg
reviewed
Sep 27, 2023
josvazg
approved these changes
Sep 27, 2023
Collaborator
josvazg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3cddc6b to
c118f21
Compare
d0edacb to
18706ed
Compare
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).