Skip to content

CLOUDP-199666: Support Atlas for government #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2023
Merged

CLOUDP-199666: Support Atlas for government #1135

merged 1 commit into from
Sep 28, 2023

Conversation

@helderjs
Copy link
Collaborator

@helderjs helderjs commented Sep 20, 2023

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/66cbc77fe72b849db79ff2a4b0780e4a3d72e505

@helderjs helderjs marked this pull request as draft September 22, 2023 13:23
@helderjs helderjs force-pushed the CLOUDP-199666-ako-for-gov branch from bf2264f to 2e857b5 Compare September 22, 2023 15:18
@helderjs helderjs marked this pull request as ready for review September 22, 2023 15:24
@helderjs helderjs force-pushed the CLOUDP-199666-ako-for-gov branch 2 times, most recently from 99f285c to 5ff40b4 Compare September 22, 2023 17:25
josvazg
josvazg reviewed Sep 25, 2023
View reviewed changes
josvazg
josvazg reviewed Sep 25, 2023
View reviewed changes
josvazg
josvazg reviewed Sep 25, 2023
View reviewed changes
josvazg
josvazg reviewed Sep 25, 2023
View reviewed changes
josvazg
josvazg reviewed Sep 25, 2023
View reviewed changes
@helderjs helderjs requested a review from josvazg September 26, 2023 15:47
josvazg
josvazg reviewed Sep 27, 2023
View reviewed changes
josvazg
josvazg reviewed Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for that misleading naming issue

Not sure: Does this PR depend on other (#1124 ?) to merge first?

josvazg
josvazg approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case there are no deps

@helderjs helderjs force-pushed the CLOUDP-199666-ako-for-gov branch from d86dc15 to 66cbc77 Compare September 27, 2023 08:39
@josvazg
Copy link
Collaborator

josvazg commented Sep 27, 2023

👍

igor-karpukhin
igor-karpukhin approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@helderjs helderjs merged commit f014006 into main Sep 28, 2023
@helderjs helderjs deleted the CLOUDP-199666-ako-for-gov branch September 28, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josvazg josvazg josvazg approved these changes

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@roothorp roothorp Awaiting requested review from roothorp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@helderjs @josvazg @igor-karpukhin