CRD changes don't get noticed by operator

[fireba11]

If you set resource limits as described in #176 and change the values operator doesn't notice any changes.
Expected behaviour would be for it to apply the new values.

I haven't tested in detail if that is true for everything.
Top level specs like version changes work, below spec.containers it doesn't get noticed any more apparently.

[chatton]

Hi @fireba11 thanks for the report,

there were some issues with the arbitrary configuration that have been fixed and will make it into the next release.

I'll let you know once the next version of the operator is released and you can test this again.

[chatton]

Hi @fireba11 could you try again with version 0.2.1 of the operator? Closing this issue now, please re-open if the problem hasn't been resolved!

[fireba11]

Hi, i tested the new version and have good and bad ..
the change got noticed and applied, but after recreating all 3 nodes operator kept throwing errors every couple seconds:

2020-09-10T08:18:53.255Z INFO mongodb/replica_set_controller.go:142 Reconciling MongoDB {"ReplicaSet": "mongo-test/mongodb"}
2020-09-10T08:18:53.292Z DEBUG mongodb/replica_set_controller.go:165 Ensuring the service exists {"ReplicaSet": "mongo-test/mongodb"}
2020-09-10T08:18:53.297Z INFO mongodb/replica_set_controller.go:294 The service already exists... moving forward: services "mongodb-svc" already exists {"ReplicaSet": "mongo-test/mongodb"}
2020-09-10T08:18:53.297Z DEBUG mongodb/replica_set_controller.go:179 Creating/Updating StatefulSet {"ReplicaSet": "mongo-test/mongodb"}
2020-09-10T08:18:53.303Z DEBUG mongodb/replica_set_controller.go:191 Ensuring StatefulSet is ready, with type: RollingUpdate {"ReplicaSet": "mongo-test/mongodb"}
2020-09-10T08:18:53.303Z INFO mongodb/replica_set_controller.go:281 StatefulSet Readiness {"ReplicaSet": "mongo-test/mongodb", "isReady": true, "hasPerformedUpgrade": false, "areEqual": true}
2020-09-10T08:18:53.303Z DEBUG mongodb/replica_set_controller.go:203 Resetting StatefulSet UpdateStrategy {"ReplicaSet": "mongo-test/mongodb"}
2020-09-10T08:18:53.304Z DEBUG mongodb/replica_set_controller.go:209 Setting MongoDB Annotations {"ReplicaSet": "mongo-test/mongodb"}
2020-09-10T08:18:53.311Z WARN mongodb/replica_set_controller.go:216 Error setting annotations: MongoDB.mongodb.com "mongodb" is invalid: spec.users: Required value {"ReplicaSet": "mongo-test/mongodb"}
github.com/mongodb/mongodb-kubernetes-operator/pkg/controller/mongodb.(*ReplicaSetReconciler).Reconcile
/go/pkg/controller/mongodb/replica_set_controller.go:216
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.5.2/pkg/internal/controller/controller.go:256
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.5.2/pkg/internal/controller/controller.go:232
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.5.2/pkg/internal/controller/controller.go:211
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
/root/go/pkg/mod/k8s.io/apimachinery@v0.17.5/pkg/util/wait/wait.go:152
k8s.io/apimachinery/pkg/util/wait.JitterUntil
/root/go/pkg/mod/k8s.io/apimachinery@v0.17.5/pkg/util/wait/wait.go:153
k8s.io/apimachinery/pkg/util/wait.Until
/root/go/pkg/mod/k8s.io/apimachinery@v0.17.5/pkg/util/wait/wait.go:88

[fireba11]

Hm, i just noticed i had the security block commented out, re-added it and it went quiet.
Not sure if that warrants more investigation, maybe except the validation of the crd since i can apparently apply things operator can't work with ;-)

[chatton]

it sounds like there is an issue alright, it shouldn't be possible to apply something without the users array in the first place, I will investigate this, thanks for the update!

[chatton]

@fireba11 it looks like the security object is considered optional but the users array is mandatory, meaning when you comment out the entire security object it mistakenly thinks everything is okay, I'll update the CRD shortly!