Skip to content
This repository was archived by the owner on Dec 12, 2025. It is now read-only.

Conversation

@chatton
Copy link
Contributor

@chatton chatton commented Sep 14, 2020

All Submissions:

  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

closes #178

Users is a mandatory field under spec.security.users but spec.security itself was not mandatory, meaning if you remove security the CRD is successfully validated and there will be errors when operator attempts to update the resource during reconciliation.

Copy link
Contributor

@rodrigovalin rodrigovalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chatton chatton merged commit a9427d1 into master Sep 14, 2020
@chatton chatton deleted the make_security_a_mandatory_crd_field branch September 14, 2020 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRD changes don't get noticed by operator

3 participants