helm-charts - remove unused values registry.appDb and community.name
#411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.3.1 Release Notes |
MaciejKaras
added
the
skip-changelog
MaciejKaras
removed
the
skip-changelog
MaciejKaras
commented
Sep 5, 2025
| initOpsManager: quay.io/mongodb | ||
| opsManager: quay.io/mongodb | ||
| initAppDb: quay.io/mongodb | ||
| appDb: quay.io/mongodb |
Collaborator
Author
There was a problem hiding this comment.
q: should we mention this in release-notes?
Contributor
There was a problem hiding this comment.
What user face effect(s) does this have?
Collaborator
Author
There was a problem hiding this comment.
if for example they specify overrides for values that don't exist (were removed), they not even know about it:
helm template --set key1=val1 test ./helm_chart
didn't show any warnings
Contributor
There was a problem hiding this comment.
I don't think we need a release note for this given that it is a no-op value.
anandsyncs
approved these changes
Sep 5, 2025
m1kola
approved these changes
Sep 9, 2025
Contributor
m1kola
left a comment
m1kola
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
| initOpsManager: quay.io/mongodb | ||
| opsManager: quay.io/mongodb | ||
| initAppDb: quay.io/mongodb | ||
| appDb: quay.io/mongodb |
Contributor
There was a problem hiding this comment.
I don't think we need a release note for this given that it is a no-op value.
MaciejKaras
added
the
skip-changelog
mihaigalos
pushed a commit
to mihaigalos/mongodb-kubernetes
that referenced
this pull request
Sep 10, 2025
…me` (mongodb#411) # Summary Remove unused helm-charts values (no usages in template files): - `registry.appDb` - `community.name` ## Proof of Work Passing CI tests. ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you added changelog file? - use `skip-changelog` label if not needed - refer to [Changelog files and Release Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes) section in CONTRIBUTING.md for more details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused helm-charts values (no usages in template files):
registry.appDbcommunity.nameProof of Work
Passing CI tests.
Checklist
skip-changeloglabel if not needed