Skip to content

helm-charts - remove unused values registry.appDb and community.name #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaciejKaras merged 2 commits into from
Sep 9, 2025
Merged

helm-charts - remove unused values registry.appDb and community.name #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21615d5
helm-charts - remove unused values `registry.appDb` and `community.name`
MaciejKaras Sep 5, 2025
a30badf
Merge branch 'master' into maciejk/helm-charts-cleanup
MaciejKaras Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions helm_chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ registry:
initOpsManager: quay.io/mongodb
opsManager: quay.io/mongodb
initAppDb: quay.io/mongodb
appDb: quay.io/mongodb
Copy link
Collaborator Author

@MaciejKaras MaciejKaras Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: should we mention this in release-notes?

Copy link
Contributor

@anandsyncs anandsyncs Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What user face effect(s) does this have?

Copy link
Collaborator Author

@MaciejKaras MaciejKaras Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if for example they specify overrides for values that don't exist (were removed), they not even know about it:

helm template --set key1=val1 test ./helm_chart

didn't show any warnings

Copy link
Contributor

@m1kola m1kola Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a release note for this given that it is a no-op value.

agent: quay.io/mongodb

# This is only used by the MongoDBCommunity resource reconciler - START
Expand All @@ -200,7 +199,6 @@ community:
version: 108.0.2.8729-1
registry:
agent: quay.io/mongodb
name: mongodb-database
resource:
name: mongodb-replica-set
version: 4.4.0
Expand Down
1 change: 0 additions & 1 deletion scripts/dev/contexts/e2e_smoke
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ source "${script_dir}/root-context"
source "${script_dir}/variables/om70"

export DATABASE_REGISTRY="${QUAY_REGISTRY}"
export APPDB_REGISTRY="${QUAY_REGISTRY}"
export INIT_OPS_MANAGER_REGISTRY="${QUAY_REGISTRY}"
export OPS_MANAGER_REGISTRY="${QUAY_REGISTRY}"
export OPERATOR_REGISTRY="${QUAY_REGISTRY}"
Expand Down
1 change: 0 additions & 1 deletion scripts/dev/contexts/e2e_static_smoke
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ source "${script_dir}/root-context"
source "${script_dir}/variables/om70"

export DATABASE_REGISTRY="${QUAY_REGISTRY}"
export APPDB_REGISTRY="${QUAY_REGISTRY}"
export INIT_OPS_MANAGER_REGISTRY="${QUAY_REGISTRY}"
export OPS_MANAGER_REGISTRY="${QUAY_REGISTRY}"
export OPERATOR_REGISTRY="${QUAY_REGISTRY}"
Expand Down
1 change: 0 additions & 1 deletion scripts/dev/contexts/evg-private-context
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ export INIT_OPS_MANAGER_REGISTRY=${INIT_IMAGES_REGISTRY-"${QUAY_REGISTRY}"}
export INIT_DATABASE_REGISTRY=${INIT_IMAGES_REGISTRY:-"${QUAY_REGISTRY}"}
export DATABASE_REGISTRY=${INIT_IMAGES_REGISTRY:-"${QUAY_REGISTRY}"}
export OPS_MANAGER_REGISTRY=${QUAY_REGISTRY}
export APPDB_REGISTRY=${QUAY_REGISTRY}
export MONGODB_ENTERPRISE_DATABASE_IMAGE="${INIT_IMAGES_REGISTRY}/mongodb-kubernetes-database"
export INIT_DATABASE_IMAGE_REPOSITORY="${INIT_IMAGES_REGISTRY}/mongodb-kubernetes-init-database"
export MDB_AGENT_IMAGE_REPOSITORY="${INIT_IMAGES_REGISTRY}/mongodb-agent"
Expand Down
1 change: 0 additions & 1 deletion scripts/dev/contexts/local-defaults-context
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export INIT_DATABASE_IMAGE_REPOSITORY="${BASE_REPO_URL_SHARED}/mongodb-kubernete
export DATABASE_REGISTRY=${BASE_REPO_URL_SHARED:-"${QUAY_REGISTRY}"}
export OPS_MANAGER_REGISTRY="${QUAY_REGISTRY}"
export MONGODB_REPO_URL="${QUAY_REGISTRY}"
export APPDB_REGISTRY="${QUAY_REGISTRY}"
export MONGODB_ENTERPRISE_DATABASE_IMAGE="${INIT_IMAGES_REGISTRY}/mongodb-kubernetes-database"
export MDB_AGENT_IMAGE_OPERATOR_VERSION=latest
export MDB_AGENT_IMAGE_REPOSITORY="${BASE_REPO_URL_SHARED}/mongodb-agent"
Expand Down
1 change: 0 additions & 1 deletion scripts/dev/contexts/variables/om60
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ export CUSTOM_MDB_PREV_VERSION=5.0.7
export CUSTOM_APPDB_VERSION=6.0.21-ent
export TEST_MODE=opsmanager
export OPS_MANAGER_REGISTRY="${BASE_REPO_URL}"
export APPDB_REGISTRY="${BASE_REPO_URL}"
1 change: 0 additions & 1 deletion scripts/dev/contexts/variables/om70
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ export AGENT_IMAGE="${MDB_AGENT_IMAGE_REPOSITORY}:${AGENT_VERSION}"
export CUSTOM_APPDB_VERSION=7.0.18-ent
export TEST_MODE=opsmanager
export OPS_MANAGER_REGISTRY="${BASE_REPO_URL}"
export APPDB_REGISTRY="${BASE_REPO_URL}"
1 change: 0 additions & 1 deletion scripts/dev/contexts/variables/om80
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ export AGENT_IMAGE="${MDB_AGENT_IMAGE_REPOSITORY}:${AGENT_VERSION}"
export CUSTOM_APPDB_VERSION=8.0.6-ent
export TEST_MODE=opsmanager
export OPS_MANAGER_REGISTRY="${BASE_REPO_URL}"
export APPDB_REGISTRY="${BASE_REPO_URL}"
1 change: 0 additions & 1 deletion scripts/funcs/operator_deployment
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ get_operator_helm_values() {
"registry.initDatabase=${INIT_DATABASE_REGISTRY}"
"registry.agent=${AGENT_BASE_REGISTRY:-${REGISTRY}}"
"registry.opsManager=${OPS_MANAGER_REGISTRY}"
"registry.appDb=${APPDB_REGISTRY}"
"registry.database=${database_registry}"
"opsManager.name=${OPS_MANAGER_NAME:=mongodb-enterprise-ops-manager-ubi}"
"database.name=${database_name:=mongodb-kubernetes-database}"
Expand Down
Loading