Fix search (and vector search) index errors - #6153
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses failing search/vector-search specs and adjusts instance-level vector search query construction to avoid using $vectorSearch.filter for “exclude self”, instead applying self-exclusion via a separate $match stage.
Changes:
- Extend test client configuration to pass
direct_connectionwhen provided by the URI. - Make search-index specs more robust against Atlas-normalized index definitions and index ordering differences.
- Update
#vector_search/#auto_embed_searchinstance pipelines to exclude the source document post-search and add targeted unit tests for the constructed aggregation pipeline.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spec/spec_helper.rb | Passes direct_connection from the configured MongoDB URI into the test client options. |
| spec/mongoid/search_indexable_spec.rb | Adds pipeline-construction unit tests; makes Atlas integration expectations more tolerant of server normalization and ordering. |
| lib/mongoid/search_indexable.rb | Refactors instance-level vector search to use a post-search $match for self-exclusion and over-fetches by 1 to avoid short counts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few errors in tests with search and vector search tests; also fixes an issue with
vector_searchandauto_embed_searchdue to filter being used instead of a separate$matchstage.