test(NODE-3719,NODE-3543): fix unified runner to not pass uri opts in object and unskip lb tests #3133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
added a commit
that referenced
this pull request
Feb 8, 2022
- #3133 unskipped two tests that fail when 'auth' is enabled. This is due to the same 'ping' issue as many other spec tests so they are skipped for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3719, NODE-3543
What is changing?
Fixed the unified runner to not pass in URI options as an object, since that behavior is incorrect for URI-only options (like
loadBalanced, and since they are already included in the generated URI string anyway.Is there new documentation needed for these changes?
N/A
What is the motivation for this change?
Spec compliance review
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>