Skip to content

test(NODE-3719,NODE-3543): fix unified runner to not pass uri opts in object and unskip lb tests #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbbeeken merged 2 commits into from
Feb 7, 2022
Merged

test(NODE-3719,NODE-3543): fix unified runner to not pass uri opts in object and unskip lb tests #3133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52cb4dd
test: fix unified runner to not pass uri opts in object and unskip lb…
dariakp Feb 7, 2022
05e058d
test: update ticket references on skipped lb tests
dariakp Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions test/integration/load-balancers/load_balancers.spec.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,19 @@ const SKIP = [
// Verified they use the same connection but the Node implementation executes
// a getMore before the killCursors even though the stream is immediately
// closed.
// TODO(NODE-3970): implement and reference a node specific integration test for this
'change streams pin to a connection',
'errors during the initial connection hello are ignore',

// NOTE: The following three tests are skipped pending a decision made on DRIVERS-1847, since
// pinning the connection on any getMore error is very awkward in node and likely results
// in sub-optimal pinning.
// TODO(DRIVERS-1847): The following three tests are skipped pending a decision made on DRIVERS-1847,
// since pinning the connection on any getMore error is very awkward in node and likely results
// in sub-optimal pinning.
'pinned connections are not returned after an network error during getMore',
'pinned connections are not returned to the pool after a non-network error on getMore',
'stale errors are ignored',
// NOTE: The driver correctly fails these 2 tests in non LB mode for server versions greater than 3.4.
// In versions that are 3.4 or less an error still occurs but a different one (connection closes).
// TODO(NODE-3543): fix the path-ing that will produce errors for older servers
'operations against non-load balanced clusters fail if URI contains loadBalanced=true',
'operations against non-load balanced clusters succeed if URI contains loadBalanced=false',

// This test is skipped because it assumes drivers attempt connections on the first operation,
// but Node has a connect() method that is called before the first operation is ever run.
// TODO(NODE-2149): Refactor connect()
'errors during the initial connection hello are ignored',

...(process.env.SERVERLESS
Expand Down
1 change: 0 additions & 1 deletion test/tools/unified-spec-runner/entities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ export class UnifiedMongoClient extends MongoClient {
constructor(uri: string, description: ClientEntity) {
super(uri, {
monitorCommands: true,
...description.uriOptions,
...getEnvironmentalOptions(),
...(description.serverApi ? { serverApi: description.serverApi } : {})
});
Expand Down