fix: Go SDK validation uses the fresh FOAS instead of the stale committed spec - #1474
Merged
Conversation
oarbusi
marked this pull request as ready for review
September 4, 2026 14:00
oarbusi
requested review from
andreaangiolillo,
chrysanthi-m,
drinkbird,
lovisaberggren,
maks-m-mongo-leaf,
saisundar and
wtrocki
September 4, 2026 14:00
wtrocki
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The "Validate the FOAS can be used with the Go SDK" step copies the freshly built
openapi-foas.yamltoatlas-sdk-go/openapi/atlas-sdk.yamland runsmake -e openapi-pipeline, but never exportsOPENAPI_FILE_NAME. The SDK'stools/scripts/generate.shfalls back to its defaultatlas-api.yaml(see https://github.com/mongodb/atlas-sdk-go/blob/897c05e3381d7f0158ca3c7825c7835fbde8d8fe/tools/scripts/generate.sh#L14), so the pipeline transforms and validates the stale spec committed in the SDK repo, and the fresh FOAS is never read. This required check therefore passes even when the new spec would break SDK generation (false-pass gate).Confirmed in CI logs (e.g. run https://github.com/mongodb/openapi/actions/runs/33871860221): the step prints
Running transformation based on atlas-api.yamland its env contains noOPENAPI_FILE_NAME.Fix
Export
OPENAPI_FILE_NAME="atlas-sdk.yaml"in the stepVerification
A Release Runner run on this branch should show
Running transformation based on atlas-sdk.yamlin the "Run Required Validations" job log.