SPEC-1221 DuplicateKey error is not reported as a top-level command error #482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behavior was:
The behavior after https://jira.mongodb.org/browse/SERVER-38583 is:
This error reporting change is going to be backported to 4.0.
For now I simply removed the
errorCodeName: DuplicateKeyassertions to get the tests to pass regardless of how the error is reported. Alternatively we could change the definition oferrorCodeNameto also look at error codes inwriteErrorsbut since writeErrors don't havecodeNamewe would either need to (re)introduceerrorCode: 11000or use the existingerrorContains: duplicate key error.