Skip to content

SPEC-1221 DuplicateKey error is not reported as a top-level command error #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2019
Merged

SPEC-1221 DuplicateKey error is not reported as a top-level command error #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions source/transactions-convenient-api/tests/callback-retry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@
}
},
"result": {
"errorCodeName": "DuplicateKey",
"errorLabelsOmit": [
"TransientTransactionError",
"UnknownTransactionCommitResult"
Expand All @@ -218,7 +217,6 @@
}
},
"result": {
"errorCodeName": "DuplicateKey",
"errorLabelsOmit": [
"TransientTransactionError",
"UnknownTransactionCommitResult"
Expand Down
5 changes: 3 additions & 2 deletions source/transactions-convenient-api/tests/callback-retry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,11 @@ tests:
session: session0
document: { _id: 1 }
result:
errorCodeName: DuplicateKey
errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
result:
errorCodeName: DuplicateKey
# Don't assert on errorCodeName because (after SERVER-38583) the
# DuplicateKey is reported in writeErrors, not as a top-level
# command error.
errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
expectations:
-
Expand Down
1 change: 0 additions & 1 deletion source/transactions/tests/abort.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,6 @@
}
},
"result": {
"errorCodeName": "DuplicateKey",
"errorLabelsOmit": [
"TransientTransactionError",
"UnknownTransactionCommitResult"
Expand Down
4 changes: 3 additions & 1 deletion source/transactions/tests/abort.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,9 @@ tests:
document:
_id: 1
result:
errorCodeName: DuplicateKey
# Don't assert on errorCodeName because (after SERVER-38583) the
# DuplicateKey is reported in writeErrors, not as a top-level
# command error.
errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
# Make sure the server aborted the transaction.
- name: insertOne
Expand Down
1 change: 0 additions & 1 deletion source/transactions/tests/error-labels.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
]
},
"result": {
"errorCodeName": "DuplicateKey",
"errorLabelsOmit": [
"TransientTransactionError",
"UnknownTransactionCommitResult"
Expand Down
4 changes: 3 additions & 1 deletion source/transactions/tests/error-labels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ tests:
- _id: 1
- _id: 1
result:
errorCodeName: DuplicateKey
# Don't assert on errorCodeName because (after SERVER-38583) the
# DuplicateKey is reported in writeErrors, not as a top-level
# command error.
errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
- name: abortTransaction
object: session0
Expand Down