Skip to content

Moped 2.0.0 / Mongoid 4.0.0 support#3

Closed
pawelniewie wants to merge 4 commits intomongoid:masterfrom
pawelniewie:moped-2.0.0
Closed

Moped 2.0.0 / Mongoid 4.0.0 support#3
pawelniewie wants to merge 4 commits intomongoid:masterfrom
pawelniewie:moped-2.0.0

Conversation

@pawelniewie
Copy link
Copy Markdown

No description provided.

@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Jan 6, 2014

There're a lot of failing specs.

I'd also want to make this work for both Mongoid3 and 4, which can be done using something similar to what's described in http://artsy.github.io/blog/2013/11/07/upgrading-to-mongoid4. If you make this work for v4 though I can do the latter part.

@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Jan 6, 2014

Note that I did fix the specs upstream.

Looks like Moped 2.0's node no longer has something called resolve_address, so the stub in the moped_session_helper is at least half of the problem.

@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Jan 7, 2014

Fixed via dblock@7228fb1, thanks for contributing - your code is mostly what it needed to be for Mongoid 4.

@dblock dblock closed this Jan 7, 2014
@pawelniewie
Copy link
Copy Markdown
Author

Thanks for merging it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants