Moped 2.0.0 / Mongoid 4.0.0 support#3
Closed
pawelniewie wants to merge 4 commits intomongoid:masterfrom
pawelniewie:moped-2.0.0
Closed
Moped 2.0.0 / Mongoid 4.0.0 support#3pawelniewie wants to merge 4 commits intomongoid:masterfrom pawelniewie:moped-2.0.0
pawelniewie wants to merge 4 commits intomongoid:masterfrom
pawelniewie:moped-2.0.0
Conversation
Collaborator
|
There're a lot of failing specs. I'd also want to make this work for both Mongoid3 and 4, which can be done using something similar to what's described in http://artsy.github.io/blog/2013/11/07/upgrading-to-mongoid4. If you make this work for v4 though I can do the latter part. |
Collaborator
|
Note that I did fix the specs upstream. Looks like Moped 2.0's |
Collaborator
|
Fixed via dblock@7228fb1, thanks for contributing - your code is mostly what it needed to be for Mongoid 4. |
Author
|
Thanks for merging it in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.