Added support for "base" in config options, in order to do a zero-based position#12
Merged
pyromaniac merged 3 commits intomongoid:masterfrom Jan 10, 2013
johnnyshields:master
Merged
Added support for "base" in config options, in order to do a zero-based position#12pyromaniac merged 3 commits intomongoid:masterfrom johnnyshields:master
pyromaniac merged 3 commits intomongoid:masterfrom
johnnyshields:master
Conversation
…ed position. The default is 1, which keeps current behavior intact. There is an added public accessor "orderable_base" to get this attribute. Have added appropriate Rspec tests. Have also bumped minor version. According to sem-ver it's an API change but does not break the existing API or change existing behavior. Lastly, please look at the change to "bottom_orderable_position" method and confirm it is suitable. I believe are the ".map(&:to_i).max" part are Ruby array methods, not a mongo instruction, so it should affect performance.
Member
Author
|
This should be good to merge. Looks like the only Travis failing is Ruby 1.9.2 + MONGOID_VERSION='~> 3.0.0.rc', which should be deleted since I believe Mongoid 3 requires Ruby >= 1.9.3 |
…readme https://github.com/mongoid/mongoid, Mongoid 3 is tested against Ruby 1.9.3 or greater.
Member
Author
|
Et voila. Travis is green. |
pyromaniac
added a commit
that referenced
this pull request
Jan 10, 2013
Added support for "base" in config options, in order to do a zero-based position
Collaborator
|
Perfect, thanks! |
Member
Author
|
Cheers!! |
Member
Author
|
Oh, d'oh forgot to add readme. Please add in this line: # orderable :base => 0 # count position from zero as the top-most value (1 is the default value) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for "base" in config options, in order to do a zero-based position. The reason for this is that Ruby, MongoDB, and Javascript all use zero-based arrays as a standard, so in my app I found I was doing a lot of -1 when reading / +1 when writing.
The default config value is 1, which keeps current behavior intact.
There is an added public accessor "orderable_base" to get this attribute.
Have added appropriate Rspec tests.
Have also bumped minor version. According to sem-ver it's an API change but does not break the existing API or change existing behavior.
Lastly, please look at the change to "bottom_orderable_position" method and confirm it is suitable. I believe are the ".map(&:to_i).max" part are Ruby array methods, not a mongo instruction, so it should not affect performance.