Support pass-thru of Mongoid field alias (:as parameter)#15
Merged
pyromaniac merged 2 commits intomongoid:masterfrom Oct 10, 2013
Merged
Support pass-thru of Mongoid field alias (:as parameter)#15pyromaniac merged 2 commits intomongoid:masterfrom
pyromaniac merged 2 commits intomongoid:masterfrom
Conversation
…g Mongoid Orderable field
Collaborator
|
Could you please add backward compatibility for mongoid 2? |
Member
Author
|
@pyromaniac this uses a native feature on mongoid which is only available in v3 and greater. In mongoid two, the parameter should not be used. |
Collaborator
|
Yeah, I know, but according to specs, you should add a |
- Ensure specs pass on Mongoid 2
Member
Author
|
Done and passing. I had to make the modification to the spec itself, since actual code is backwards compatible. |
pyromaniac
added a commit
that referenced
this pull request
Oct 10, 2013
Support pass-thru of Mongoid field alias (:as parameter)
Collaborator
|
Thanks, merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support pass-thru of Mongoid field alias (
:asparameter) to underlying Mongoid Orderable fieldExample:
This will store the orderable field in the DB as a minified name
pos, however you can access it in Ruby asposition