Fix for Mongoid Identity map combined with Scoped Orderable#16
Merged
pyromaniac merged 3 commits intomongoid:masterfrom Oct 11, 2013
Merged
Fix for Mongoid Identity map combined with Scoped Orderable#16pyromaniac merged 3 commits intomongoid:masterfrom
pyromaniac merged 3 commits intomongoid:masterfrom
Conversation
(Also includes some extra cases for Scoped Orderable for greater coverage)
pyromaniac
added a commit
that referenced
this pull request
Oct 11, 2013
Fix for Mongoid Identity map combined with Scoped Orderable
Collaborator
|
Great work! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an edge case when using Mongoid Identity Map combined with Scoped Orderable. Scoped Orderable uses a method
orderable_scope_changed?which uses a db query to check that item is no longer present in the original scope. However, when the Identity Map is enabled, this query is intercepted and it uses the (now stale) cached object, which gives a false result the item still appears to be in the original scope.The solution is to wrap the query in a Mongoid.unit_of_work block to bypass the identity map on a one-off basis. See http://mongoid.org/en/mongoid/docs/identity_map.html.
I've committed the specs before the code fix so you can checkout commit ef3bb39 and replay the failing case.