Added support for Mongoid 4.x.#18
Merged
pyromaniac merged 1 commit intomongoid:masterfrom Oct 22, 2013
Merged
Conversation
Collaborator
|
Amazing! But could you remove 1.9.2 support, or fix it please? |
Contributor
Author
|
Fixed, amended. |
pyromaniac
added a commit
that referenced
this pull request
Oct 22, 2013
Added support for Mongoid 4.x.
Collaborator
|
Fukken incredible, thanks! |
Contributor
Author
|
Don't mention it :-) |
Contributor
Author
|
Oh and thanks for the gem, we use it at http://artsy.net all over the place. |
Collaborator
|
Taso Du Val, who is sitting right next to me, says "Hello". |
Collaborator
|
Also, you are welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mongoid 4.x has removed
Mongoid::Observer, so we use that to test for the Mongoid version. There're two changes:inctakes a hash andindex_specificationsreplacedindex_options.I did a bit of upgrading of default mongoid versions in Gemfile, ran all these: