Skip to content

Added support for Mongoid 4.x.#18

Merged
pyromaniac merged 1 commit intomongoid:masterfrom
dblock:mongoid-4x
Oct 22, 2013
Merged

Added support for Mongoid 4.x.#18
pyromaniac merged 1 commit intomongoid:masterfrom
dblock:mongoid-4x

Conversation

@dblock
Copy link
Copy Markdown
Contributor

@dblock dblock commented Oct 22, 2013

Mongoid 4.x has removed Mongoid::Observer, so we use that to test for the Mongoid version. There're two changes: inc takes a hash and index_specifications replaced index_options.

I did a bit of upgrading of default mongoid versions in Gemfile, ran all these:

rm Gemfile.lock ; MONGOID_VERSION=2 bundle install ; MONGOID_VERSION=2 bundle exec rspec spec/mongoid/orderable_spec.rb # also with Ruby 1.8.7
rm Gemfile.lock ; MONGOID_VERSION=3 bundle install ; MONGOID_VERSION=3 bundle exec rspec spec/mongoid/orderable_spec.rb
rm Gemfile.lock ; MONGOID_VERSION=4 bundle install ; MONGOID_VERSION=4 bundle exec rspec spec/mongoid/orderable_spec.rb

@pyromaniac
Copy link
Copy Markdown
Collaborator

Amazing! But could you remove 1.9.2 support, or fix it please?

@dblock
Copy link
Copy Markdown
Contributor Author

dblock commented Oct 22, 2013

Fixed, amended.

pyromaniac added a commit that referenced this pull request Oct 22, 2013
Added support for Mongoid 4.x.
@pyromaniac pyromaniac merged commit 2337541 into mongoid:master Oct 22, 2013
@pyromaniac
Copy link
Copy Markdown
Collaborator

Fukken incredible, thanks!

@dblock
Copy link
Copy Markdown
Contributor Author

dblock commented Oct 22, 2013

Don't mention it :-)

@dblock
Copy link
Copy Markdown
Contributor Author

dblock commented Oct 22, 2013

Oh and thanks for the gem, we use it at http://artsy.net all over the place.

@pyromaniac
Copy link
Copy Markdown
Collaborator

Taso Du Val, who is sitting right next to me, says "Hello".

@pyromaniac
Copy link
Copy Markdown
Collaborator

Also, you are welcome.

@dblock dblock deleted the mongoid-4x branch October 19, 2015 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants