Inherit orderable_configurations#28
Merged
pyromaniac merged 2 commits intomongoid:masterfrom Jun 25, 2014
j-miyake:inherit_orderable_conf
Merged
Inherit orderable_configurations#28pyromaniac merged 2 commits intomongoid:masterfrom j-miyake:inherit_orderable_conf
pyromaniac merged 2 commits intomongoid:masterfrom
j-miyake:inherit_orderable_conf
Conversation
Collaborator
|
This is not the complete patch, unfortunately. Inherited class configuration will affect parent classes. To avoid this just change https://github.com/pyromaniac/mongoid_orderable/blob/master/lib/mongoid/orderable/orderable_class.rb#L37 to something like |
Member
|
Maybe better to name this :orderable_config ? |
Collaborator
|
Whatever actually |
Author
|
@pyromaniac - Definetely. I revised the code and added a spec. Thanks! |
pyromaniac
added a commit
that referenced
this pull request
Jun 25, 2014
Inherit orderable_configurations
Collaborator
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for https://github.com/pyromaniac/mongoid_orderable/pull/26#issuecomment-46937974