Fix Issue - reset a single column when orderable_scope changed instead of removing it from list#30
Merged
pyromaniac merged 2 commits intomongoid:masterfrom Sep 1, 2014
Conversation
…d of removing it from list
pyromaniac
added a commit
that referenced
this pull request
Sep 1, 2014
Fix Issue - reset a single column when orderable_scope changed instead of removing it from list
Collaborator
|
Important patch. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have a model having multiple columns, both scoped differently, then if the scope of one position field is changed it currently removes the element from the list, resulting in changing the position of the other position fields as well.
However it should not be such and set the position for that particular column only to nil.
The added spec explains in detail the issue.