Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps oxc tooling (oxlint/oxfmt/tsgolint) across workspaces + lockfile, and applies resulting typing/lint-driven cleanup (remove casts, adjust config).
Changes:
- Upgrade
oxfmt,oxlint,oxlint-tsgolintversions in root + packages + lockfile. - Update
packages/oxlint-configrule config (no-constant-binary-expressionoptions). - Remove many unnecessary TS casts / tighten inferred types across FE/BE code + tests (incl. Storybook metadata, Vite/Vitest config).
Reviewed changes
Copilot reviewed 75 out of 76 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile refresh for oxc bump + transitive updates |
| package.json | Bump root oxc tool versions |
| packages/oxlint-config/rules/enabled.jsonc | Update rule config to new option shape |
| packages/util/package.json | Bump oxlint/tsgolint in util workspace |
| packages/tsup-config/package.json | Bump oxlint/tsgolint in tsup-config workspace |
| packages/schemas/package.json | Bump oxlint/tsgolint in schemas workspace |
| packages/release/package.json | Bump oxlint/tsgolint in release workspace |
| packages/funbox/package.json | Bump oxlint/tsgolint in funbox workspace |
| packages/contracts/package.json | Bump oxlint/tsgolint in contracts workspace |
| packages/challenges/package.json | Bump oxlint/tsgolint in challenges workspace |
| packages/util/src/json.ts | Replace unsafe cast return with lint suppression + direct return |
| frontend/package.json | Bump oxlint/tsgolint in frontend workspace |
| frontend/vitest.config.ts | Remove as never cast for projects config |
| frontend/vite.config.ts | Switch build config to rolldownOptions, drop final type-cast |
| frontend/storybook/.storybook/ThemeDecorator.tsx | Small refactor for clearer fallback theme selection |
| frontend/storybook/stories/UserProfile.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/UserFlags.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/UserBadge.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/User.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/SlimSelect.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/NotificationBubble.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/InputField.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/H3.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/H2.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/FieldIndicator.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/Fa.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/DiscordAvatar.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/DataTable.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/Checkbox.stories.tsx | Remove Solid Component generic cast in Storybook meta |
| frontend/storybook/stories/ChartJs.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/Button.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/Bar.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/Balloon.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/AutoShrink.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/AsyncContent.stories.tsx | Remove unsafe component cast in Storybook meta |
| frontend/storybook/stories/AnimeSwitch.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/AnimeShow.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/AnimePresence.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/AnimeGroup.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/Anime.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/storybook/stories/AnimatedModal.stories.tsx | Remove Solid Component cast in Storybook meta |
| frontend/src/ts/utils/misc.ts | Remove promise cast in promiseWithResolvers return |
| frontend/src/ts/utils/dom.ts | Remove addEventListener cast, rely on typed handler |
| frontend/src/ts/test/test-ui.ts | Remove as string casts when setting styles |
| frontend/src/ts/test/test-logic.ts | Drop as Omit<...> cast from completed event build |
| frontend/src/ts/test/replay-ui.ts | Minor refactor of activeWord assignment |
| frontend/src/ts/test/funbox/list.ts | Remove cast on single-match return |
| frontend/src/ts/test/custom-text.ts | Remove cast on custom text limit getter |
| frontend/src/ts/states/quote-rate.ts | Remove empty-object cast on null response |
| frontend/src/ts/controllers/theme-controller.ts | Remove string casts around getCustomTheme calls |
| frontend/src/ts/controllers/sound-controller.ts | Drop as ScaleMeta cast from constructed scale data |
| frontend/src/ts/controllers/quotes-controller.ts | Drop cast when passing config event value |
| frontend/src/ts/controllers/badge-controller.ts | Drop cast when indexing badges map |
| frontend/src/ts/constants/themes.ts | Simplify ThemesList map, remove cast |
| frontend/src/ts/config/utils.ts | Remove ConfigValue import + cast in merge |
| frontend/src/ts/config/setters.ts | Remove metadata + previousValue casts |
| frontend/src/ts/components/pages/settings/custom-setting/FontFamily.tsx | Remove HTMLInputElement cast; simplify options metadata typing |
| frontend/src/ts/components/pages/settings/custom-setting/CustomBackground.tsx | Remove HTMLInputElement cast |
| frontend/src/ts/components/modals/SimpleModal.tsx | Remove validator casts |
| frontend/src/ts/components/modals/QuoteSubmitModal.tsx | Factor default language into const; reduce casts |
| frontend/src/ts/components/layout/overlays/Notifications.tsx | Simplify FaProps object creation, drop cast |
| frontend/src/ts/commandline/commandline.ts | Drop cast when mapping commands to active status |
| frontend/src/ts/collections/inbox.ts | Replace casted nested ternary with typed expression |
| frontend/tests/test/events/stats.spec.ts | Remove as InputEventData casts in helpers |
| frontend/tests/test/events/data.spec.ts | Remove as KeyupEventData casts in helpers |
| frontend/tests/controllers/preset-controller.spec.ts | Remove unnecessary as any when returning preset |
| frontend/tests/components/common/AnimatedModal.spec.tsx | Drop ModalId import + casts for showModal/hideModal |
| backend/package.json | Bump oxlint/tsgolint in backend workspace |
| backend/src/api/routes/index.ts | Remove MonkeyValidationError type import/cast for 422 response |
| backend/src/api/controllers/user.ts | Remove as RelevantUserInfo cast from omit result |
| backend/src/api/controllers/dev.ts | Remove mode as Mode cast |
| backend/tests/middlewares/auth.spec.ts | Remove NextFunction cast around vi.fn |
| backend/tests/api/controllers/user.spec.ts | Remove FirebaseError import + rejectedValue cast |
| backend/tests/api/controllers/quotes.spec.ts | Remove mockResolvedValue({} as any) |
| backend/tests/integration/dal/user.spec.ts | Remove as any on inserted settings object |
| backend/tests/integration/dal/result.spec.ts | Remove as never cast for mode2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.