Fix API docs writer pull request file limit - #186
Conversation
Raise the bounded safe-output file ceiling for regenerated API XML, keep the existing patch-size limit, and constrain the agent to API-reference routes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 6b978df: ✅ Validation status: passed
For more details, please refer to the build report. |
The representative dispatch showed that gh-aw v0.83.4 no longer recognizes claude-opus-4.7. Move to the suggested Opus 4.8 model so the agent can execute. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit d123d6a: ✅ Validation status: passed
For more details, please refer to the build report. |
The representative main/main run produced a legitimate 1,854 KB regenerated XML patch. Set a narrowly bounded 2,048 KB ceiling so that payload can reach the 500-file safe-output check without accepting the newer compiler's 4,096 KB default. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 67befb4: ✅ Validation status: passed
For more details, please refer to the build report. |
The successful safe-output validation measured a 1,857 KB patch, while signed-commit synthesis expanded its additions payload to 5,508 KB. Use a bounded 6,144 KB ceiling so the protected signed push can complete without disabling commit signing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit cdf4345: ✅ Validation status: passed
For more details, please refer to the build report. |
Use the exact SEVERITY | class | file | docId | message format required by references/reviewing.md instead of the obsolete FINDING-prefixed wording. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
When managed bindings delegate status, ownership, or callback semantics, initialize only the pinned externals/skia submodule on demand instead of inferring behavior or recursively cloning all submodules. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
|
Learn Build status updates of commit dc58c71: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit f14d25d: ✅ Validation status: passed
For more details, please refer to the build report. |
Delegate authoring, review, fact-checking, and validation policy to the API docs skill while retaining CI-specific routing, scope, native checkout, fix authorization, timebox, staging, and safe-output wiring. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 1589d10: ✅ Validation status: passed
For more details, please refer to the build report. |
Select one reviewable automated wave, initialize pinned Skia native source only for native-sensitive regenerated placeholders, authorize fixes for self-introduced critical findings, and require the current skill evidence rows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
|
Learn Build status updates of commit 22bc61e: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 3797d4f: ✅ Validation status: passed
For more details, please refer to the build report. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 1ee486e: ✅ Validation status: passed
For more details, please refer to the build report. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit f5c6143: ✅ Validation status: passed
For more details, please refer to the build report. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a6a39be-d1a6-4614-b743-2a492784eceb
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit d2268f4: ✅ Validation status: passed
For more details, please refer to the build report. |
1 participant
Summary
safe-outputs.create-pull-request.max-patch-filesfrom the default 100 to a bounded 500 and retain a bounded 6,144 KB signed-payload ceilingapi-docsskillUNSELECTEDrowsexternals/skiawithgit -C skiasharp submodule update --init --depth 1 externals/skiaand log its pinned SHAscripts/fetch-approved-context.pywith explicit repository/label selectors; do not duplicate retrieval or schema logic in this repositorynoopcompletionApproved issue context
After cloning the requested SkiaSharp branch, the workflow runs exactly:
python skiasharp/.agents/skills/api-docs/scripts/fetch-approved-context.py --repository mono/SkiaSharp-API-docs --label approved-for-context --output "$RUNNER_TEMP/api-docs-approved-context.json" --max-issues 50 --max-bytes 1048576The workflow grants only
issues: readand suppliesGH_TOKEN; issue filtering, PR exclusion, complete comment pagination, canonical camelCase schema v1, stable ordering, bounds, atomic writes, and manifest redaction remain owned by the skill script.The script logs only its canonical
CONTEXTrow and redacted single-lineISSUErows. Because gh-aw mounts$RUNNER_TEMP/gh-awrather than the whole host runner temp into the agent sandbox, the workflow copies the canonical file byte-for-byte to$RUNNER_TEMP/gh-aw/api-docs-approved-context.json, verifies it withcmp, exports that exact path as$APPROVED_ISSUE_CONTEXT_PATH, and removes both files in an always-run post step. It never reads or logs issue bodies/comments itself.Conditional native checkout
The host examines both tracked changes and newly generated untracked XML under
SkiaSharpAPI/. A file enters the native-sensitive set only when it still containsTo be added.and matches the Graphite/backend/texture/recording/context/callback/delegate/release/Vulkan/Metal/Dawn signal set. A non-empty set runs the exact pinned submodule command and printsgit -C skiasharp/externals/skia rev-parse HEAD; an empty set leaves the submodule uninitialized.Validation
d2268f449f142bac02479a1945e6605ad0862709compiled with gh-aw v0.83.4 strict schema/action validation with zero errorsmattleibow-api-docs-two-route-skillresolved to and checked out exactly12a2c5530e11b09f2a5b73e60b5145a231769dcfregenerate-stubs,agent,detection,safe_outputs, andconclusionCONTEXT | mono/SkiaSharp-API-docs | approved-for-context | 2 | 41129 | ...and individual rows for open issues Migrate inline///docs to mdoc XML (Graphite backend + pre-existing) #181 and Docs: async RequestReadPixels API (SKImage/SKSurface/GRContext, SKImageReadPixelsResult, SKImageRescaleGamma/Mode) #184; the agent-visible byte-identical copy was exported from runner tempc14bcfbab83b2182977505c251a02c058f83a321WROTE, 17 per-DocIdEVIDENCE, 3NATIVE, 3TRACE, noDEFERRED/finding rows, and 24UNSELECTEDfiles matching the remaining placeholder-bearing work setOverflowExceptioncontracts for checked size calculations and transitive callers, overbroad disposal wording, unsupported rescale-quality superlatives, an owned-bitmap example without disposal, and inconsistent structural-file arithmetic. The run proves transport, context availability, branch/native checkout, bounded orchestration, and large signed PR creation—not merge-ready generated docs.cancelledand excluded from validationconcurrency.queueextension; gh-aw reports its exit code 3 as a tooling error rather than a workflow validation failuregit diff --checkpassed;.github/aw/actions-lock.jsonis unchanged because no action dependency changedScope
No API documentation content is modified by this workflow-fix PR.