Change native artifact name to match Azure Build.#892
Merged
mattleibow merged 1 commit intoJun 27, 2019
Merged
Conversation
Changes the artifact name for the externals-download target from "native" to "native-default" to match the Azure Build. This is in conjunction with mono#889 to allow anonymous access to the native-default Azure Build artifact. Renames the unzipped folder back to "native" after downloading.
mattleibow
approved these changes
Jun 27, 2019
mattleibow
left a comment
mattleibow
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, all is looking really good. Hope to see more in the future 😉
| throw new Exception ("Specify a build ID with --azureBuildId=<ID>"); | ||
|
|
||
| var url = string.Format(AZURE_BUILD_URL, AZURE_BUILD_ID, "native"); | ||
| var artifactName = "native-default"; |
Contributor
There was a problem hiding this comment.
Using variables - wise move.
Contributor
Author
There was a problem hiding this comment.
Thanks again for your help and for maintaining this project!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes the artifact name for the externals-download target from "native" to "native-default" to match the Azure Build.
This allows the Build Preparation instructions to work as documented instead of returning a 404 error.
Bugs Fixed
Changes
Changes the artifact name from "native" to "native-default" to match the Azure Build Pipeline.
Also some minor refactoring of local string constants for the output path.
Behavioral Changes
Since the unzipped folder is named "native-default", it is renamed back to "native" so the rest of the build scripts can still work.
PR Checklist