bugfix: fix "attempt to shift left with overflow" exception - #5
Open
mwicat wants to merge 1 commit into
Open
Conversation
…2 expression results in overflow for i32 type
|
The same should be then used in If I counted well, it will be called 2x (incl. your previous patch). Then, there is another call on the next line, which also needs handling for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spotted this because it causes a few tests to fail.
The expression inside
decode_truncated_block_i32function that is used to get a bitmask for given bit_size will fail in casebit_size == 32. Expression1<<32will be evaluated first which will cause "attempt to shift left with overflow" exception since1<<32value does not fit ini32type. Let's compute the bitmask incrementally from zero instead of backward arithmetic to avoid the type overflow.