fix(sync-assets): drop redundant --quiet option - #7
Merged
Conversation
Laravel's base Command already registers `--quiet` as a global option, so declaring it in the signature throws `LogicException: An option named "quiet" already exists.` the moment the command is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Laravel's base `Illuminate\Console\Command` already registers `--quiet` as a global option. Declaring it again in the `monorail:sync-assets` signature throws the moment the command is resolved:
```
An option named "quiet" already exists.
```
This makes the command completely unusable in v0.4.0. Reproduced in a host app upgrading from 0.3.1 → 0.4.0.
Fix
Drop the redundant option from the signature — `--quiet` still works out of the box via Laravel.
Needs a quick patch release (v0.4.1).