Document singleton pattern changes in customfields handler. - #1661
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Documents the change in Moodle 5.2 that moves \core_customfield\handler::create(...) static caching/reset behavior into the base handler, and updates the Custom fields API docs accordingly.
Changes:
- Added a Moodle 5.2 developer update entry describing the base handler
create()caching/reset change (MDL-88176). - Updated Custom fields API documentation (current + 5.2) to reflect the base handler’s
create()behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| versioned_docs/version-5.2/devupdate.md | Adds a 5.2 dev update note about the base customfields handler create() caching/reset change. |
| versioned_docs/version-5.2/apis/core/customfields/index.md | Updates the 5.2 Custom fields API docs to describe the base handler create() behavior. |
| docs/apis/core/customfields/index.md | Updates the current Custom fields API docs to describe the base handler create() behavior. |
yerairogo
left a comment
There was a problem hiding this comment.
I think we should avoid calling singleton to the handler class to avoid future misconceptions. Otherwise, looks good.
Please address Copilot comments so I can approve it :)
Cheers Yerai, applied all Copilot suggestings and also changed the devupdate heading:
|
c9060c6 to
4ba5353
Compare
aanabit
left a comment
There was a problem hiding this comment.
Merging this PR based on Yerai's review.
See MDL-88176.