handle killed-by-signal process state properly#512
Merged
Conversation
Guest0x0
force-pushed
the
process-handle-signal-return
branch
from
July 22, 2026 02:41
17ae9fc to
eeff478
Compare
Guest0x0
force-pushed
the
process-handle-signal-return
branch
from
July 22, 2026 03:02
eeff478 to
e5f3871
Compare
Coverage Report for CI Build 895Coverage decreased (-0.04%) to 76.885%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Unix-like systems, when a process is killed by a signal, the process would have a special return status, differing from any normal exit code. Previously:
async fn mainis cancelled gracefully by signal, it return128 + signal_numbernormally. This is the convention used bybash/zsh, but ambiguous and not faithful (the process is actually killed by signal)@process.runetc. is killed by signal, the returned exit status is simply corruptedThis PR fixes these two problems:
async fn mainis gracefully cancelled via a signal, the program will kill itself with the same signal after finishing all the cleanup, creating an actual killed-by-signal exit statusasync fn mainwill exit withCONTROL_C_EXIT_STATUSfollowing Windows convention.@processAPI is killed by a signal, the returned exit status ofrun,.wait_pidandProcess::waitwould be-signal_number. Using negative number is unambiguous on Unix-like systems and can avoid breaking existing API. This is also the convention used by Python'ssubprocessAPI