Skip to content

use builder style API for process spawning in event loop - #523

Merged
Guest0x0 merged 1 commit into
mainfrom
simplify-process-FFI
Jul 28, 2026
Merged

use builder style API for process spawning in event loop#523
Guest0x0 merged 1 commit into
mainfrom
simplify-process-FFI

Conversation

@Guest0x0

Copy link
Copy Markdown
Collaborator

Use builder style API for creation of process spawning job, so that we can more easily add more options in the future. Also reserve an is_orphan flag for the process spawning API for potential future use.

Since #518 would require changing the API interface, I think we may also adapt the change here to Wasm as well for cleaner FFI shape? cc @peter-jerry-ye

@Guest0x0
Guest0x0 force-pushed the simplify-process-FFI branch 3 times, most recently from 7197d46 to f767e29 Compare July 28, 2026 08:58
@Guest0x0
Guest0x0 force-pushed the simplify-process-FFI branch from f767e29 to 0656e80 Compare July 28, 2026 09:11
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 941

Coverage decreased (-0.07%) to 76.986%

Details

  • Coverage decreased (-0.07%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (4 of 5 lines covered, 80.0%).
  • 2 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
src/internal/event_loop/thread_pool.mbt 5 4 80.0%

Coverage Regressions

2 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
src/internal/os_string/os_string.mbt 1 50.0%
src/tls/transport.mbt 1 83.33%

Coverage Stats

Coverage Status
Relevant Lines: 4858
Covered Lines: 3740
Line Coverage: 76.99%
Coverage Strength: 11830.27 hits per line

💛 - Coveralls

@Guest0x0 Guest0x0 added the wasm-runtime-port-required The change in this PR need to be ported to WASM runtime label Jul 28, 2026
@Guest0x0
Guest0x0 merged commit 1f78b85 into main Jul 28, 2026
21 checks passed
@Guest0x0
Guest0x0 deleted the simplify-process-FFI branch July 28, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasm-runtime-port-required The change in this PR need to be ported to WASM runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants