Handle minimum signed values in QuickCheck shrinking (#4151) * Handle minimum signed values in QuickCheck shrinking * Assert complete minimum-value shrink sequences * docs(builtin): expand documentation for integer min/max/clamp `Int64::min`, `Int64::max`, `Int64::clamp`, `UInt::min`, `UInt::max` and `UInt::clamp` carried one-line comments while their documented siblings follow the full structure. Bring all six to the same level: semantics, parameters, return behavior (including the abort when `min > max` in `clamp`) and executable examples. Continues #623 * chore: remove deprecated APIs * perf(bytes): skip redundant initialization in concatenation (#4142) * perf(bytes): skip redundant initialization in concatenation * Limit Bytes benchmark setup to benchmark runs * refactor(bigint): read each from_octets limb with a u32be pattern (#4099) * refactor(bigint): read each limb with a u32be pattern in from_octets The inner loop was a 4-iteration big-endian shift-accumulate, which is exactly one u32be read (RADIX_BIT_LEN = 32). Measured: native -34% at n=1024 / -24% at n=64, wasm-gc -46% / -42%. js is unaffected (bigint_js.mbt has its own from_octets). * bench(bigint): add from_octets benchmarks Covers the limb-fill path at n=64 and n=1024 so the u32be conversion in the previous commit is reproducible. Signed-off-by: Codex CLI Co-Authored-By: Claude Opus 5 (1M context) * test(bigint): pin RADIX_BIT_LEN so the u32be limb read can't drift Addresses the review note that `from_octets`'s tail now hard-codes a 32-bit read while `byte_per_limb` is still derived from `RADIX_BIT_LEN`. Rather than branch on the constant at runtime, the assumption is pinned by a whitebox test and named in the comment above the loop: narrowing `RADIX_BIT_LEN` now fails a test instead of silently mis-decoding. The pin uses `@test.assert_eq`, not `inspect`. A snapshot would be rewritten by `moon test --update`, which would retire the guard at exactly the moment it is supposed to fire; `assert_eq` is not auto-updatable. Verified both halves by temporarily setting the expected value to 16: the test fails with `32 != 16`, and `moon test --update` leaves it failing rather than rewriting it. A runtime fallback was considered and rejected. Restoring the old shift-accumulate loop as the "generic" arm would not actually be generic: `byte_per_limb` is `RADIX_BIT_LEN / 8`, so for the documented-legal widths 4, 12, 20 and 28 (the file only requires a multiple of 4, at most 32) that loop truncates and mis-decodes just as badly. It would trade a loud failure for a quiet one, plus a permanently dead branch that no test can reach. Co-Authored-By: Claude Opus 5 (1M context) --------- Signed-off-by: Codex CLI Co-authored-by: Claude Opus 5 (1M context) * feat: improve scalar Arbitrary * use integer literal suffix or constructor * fix: improve test strength * refactor: uniform Byte generation * adjust shrinking order of 0 * perf(bigint): use 64-bit limbs on native and wasm (#4164) Keep wasm-gc on the existing 32-bit limb implementation because wide arithmetic multi-value results regress there. --------- Signed-off-by: Codex CLI Co-authored-by: Li Fengmin <2080291162@qq.com> Co-authored-by: Yu Zhang Co-authored-by: Hongbo Zhang Co-authored-by: Claude Opus 5 (1M context) Co-authored-by: CAIMEO <38813005+CAIMEOX@users.noreply.github.com>

Uh oh!

Improve comment coverage for builtin #623

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions