Skip to content

refactor(lexer): use named regex constants#164

Merged
myfreess merged 1 commit into
masterfrom
yuxiang/refactor-lexer-named-regex
Jul 17, 2026
Merged

refactor(lexer): use named regex constants#164
myfreess merged 1 commit into
masterfrom
yuxiang/refactor-lexer-named-regex

Conversation

@hackwaly

Copy link
Copy Markdown
Collaborator

This PR refactor lexer by using named regex constants.

Closes #163

@hackwaly
hackwaly requested a review from myfreess July 17, 2026 08:07
@hackwaly
hackwaly force-pushed the yuxiang/refactor-lexer-named-regex branch from d50af06 to e465bb7 Compare July 17, 2026 08:08

@myfreess myfreess left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@myfreess

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: e465bb77ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@myfreess
myfreess merged commit 02b2dc1 into master Jul 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor lexer to use named regex constants

2 participants