perf(rational): compare without overflow or BigInt allocation - #292
Open
kokic wants to merge 2 commits into
Open
perf(rational): compare without overflow or BigInt allocation#292kokic wants to merge 2 commits into
kokic wants to merge 2 commits into
Conversation
Introduce a compare_fraction method on the Integral trait so Rational comparison can use fixed-width cross-products when they fit, with a continued-fraction fallback for Int64 products that would overflow. Move the Compare impl into rational/compare.mbt and relocate the old inline tests into rational_wbtest.mbt, adding boundary-value tests and an exhaustive int64-vs-bigint parity check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves
@rationalcomparison for fixed-width integer values: cross-multiplication stays in fixed-width arithmetic when safe, falling back to a continued-fraction algorithm only when the product would overflow, avoidingBigIntallocation entirely.Changes
compare_fractionto theIntegraltrait withInt64,Int, andBigIntimplementationsCompareimpl intorational/compare.mbtrational_wbtest.mbtCloses #291 overflow concern; includes the changelog entry for the fix.