Gif Sorter Extension - #426
Merged
Merged
Conversation
NotNite
requested changes
Jun 25, 2026
NotNite
left a comment
Member
There was a problem hiding this comment.
Your file is missing the .json extension; please rename it and I'll approve a build to run!
Contributor
Author
|
Whoops, didn't notice I forgot the file extension, thanks for responding so fast :) |
NotNite
requested changes
Jun 26, 2026
NotNite
left a comment
Member
There was a problem hiding this comment.
Hi! There's some issues that need to be resolved first before this can be merged:
- This source URL is wrong: https://github.com/chachachalga/my-moonlight-extensions/blob/a046aad7d77d88fdd558f48f3bd3c9d1d7953855/src/gifSorter/manifest.json#L11
- There are some minified variables used in this patch that are prone to breaking on Discord updates. You should match these with regex captures instead: https://github.com/chachachalga/my-moonlight-extensions/blob/a046aad7d77d88fdd558f48f3bd3c9d1d7953855/src/gifSorter/index.tsx#L26-L28
There's also some things I noticed that I strongly suggest you fix, but aren't required:
- You still have some files left over from the sample extension: https://github.com/chachachalga/my-moonlight-extensions/blob/a046aad7d77d88fdd558f48f3bd3c9d1d7953855/src/gifSorter/node.ts and https://github.com/chachachalga/my-moonlight-extensions/blob/a046aad7d77d88fdd558f48f3bd3c9d1d7953855/src/gifSorter/webpackModules/entrypoint.ts
- I highly suggest using the moonlight settings API instead of your own localStorage key.
- I noticed that this extension doesn't work right on light mode - you should consider using Discord's CSS variables, and additionally using a stylesheet instead of inline styles.
This should be the final update. Removed previous minified variable usage Added stylesheets Removed left over files from sample extension
Contributor
Author
|
I believe everything that you mentioned is now resolved. Thanks for reviewing it again! |
NotNite
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple QoL extension that allows GIF sorting via folders.