fix: update to gomod-parser 0.5.1#143
Merged
Merged
Conversation
Contributor
Author
|
@milesj would love a review, if possible |
Contributor
|
@miguelvr Can you also contribute the change directly to https://github.com/baz-scm/gomod-parser ? I don't want to have to maintain this going forward. |
Contributor
Author
@milesj already did! here's the PR baz-scm/gomod-parser#35 |
miguelvr
force-pushed
the
miguelvr/strip-ignore
branch
from
61df90c to
a237bd9
Compare
miguelvr
changed the title
Contributor
Author
|
@milesj updated the PR to pick up the fixes from the upstream |
Contributor
|
Awesome |
Run report for 64c7d050
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| ⬛️ | SetupProto(0.56.4) |
0ms | Skipped | |
| 🟩 | SyncWorkspace |
7.7ms | Passed | |
| 🟩 | SyncProject(go-toolchain) |
0.3ms | Passed | |
| ⬛️ | SetupToolchain(rust:1.95.0) |
0.5ms | Skipped | |
| 🟩 | SetupEnvironment(rust) |
359.5ms | Passed | |
| ⬛️ | InstallDependencies(rust) |
17.7ms | Skipped | |
| 🟩 | RunTask(go-toolchain:build) |
1m 11s | Passed | |
| 🟩 | RunTask(go-toolchain:check) |
1m 15s | Passed | |
| 🟩 | RunTask(go-toolchain:lint) |
1m 16s | Passed | |
| 🟩 | RunTask(go-toolchain:test) |
1m 2s | Passed |
Environment
OS: macOS
Matrix:
os = depot-macos-15
job = 0
Variables:
PROTO_LOG = trace
Changed files
.protolock
Cargo.lock
toolchains/go/Cargo.toml
toolchains/go/src/go_mod.rs
toolchains/go/src/go_work.rs
toolchains/go/tests/__fixtures__/mod-files/advanced.mod
toolchains/go/tests/__fixtures__/work-files/advanced.work
toolchains/go/tests/go_mod_test.rs
toolchains/go/tests/go_work_test.rs
Run report for 64c7d050
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| ⬛️ | SetupProto(0.56.4) |
0ms | Skipped | |
| 🟩 | SyncWorkspace |
5.2ms | Passed | |
| 🟩 | SyncProject(go-toolchain) |
0.2ms | Passed | |
| ⬛️ | SetupToolchain(rust:1.95.0) |
0.4ms | Skipped | |
| 🟩 | SetupEnvironment(rust) |
172.6ms | Passed | |
| ⬛️ | InstallDependencies(rust) |
10.2ms | Skipped | |
| 🟩 | RunTask(go-toolchain:build) |
1m 6s | Passed | |
| 🟩 | RunTask(go-toolchain:check) |
1m 50s | Passed | |
| 🟩 | RunTask(go-toolchain:lint) |
1m 51s | Passed | |
| 🟩 | RunTask(go-toolchain:test) |
2m 5s | Passed | SLOW |
Environment
OS: Linux
Matrix:
os = depot-ubuntu-24.04-4
job = 0
Variables:
PROTO_LOG = trace
Changed files
.protolock
Cargo.lock
toolchains/go/Cargo.toml
toolchains/go/src/go_mod.rs
toolchains/go/src/go_work.rs
toolchains/go/tests/__fixtures__/mod-files/advanced.mod
toolchains/go/tests/__fixtures__/work-files/advanced.work
toolchains/go/tests/go_mod_test.rs
toolchains/go/tests/go_work_test.rs
Run report for 64c7d050
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| ⬛️ | SetupProto(0.56.4) |
0.2ms | Skipped | |
| 🟩 | SyncWorkspace |
13ms | Passed | |
| 🟩 | SyncProject(go-toolchain) |
0.6ms | Passed | |
| ⬛️ | SetupToolchain(rust:1.95.0) |
2.2ms | Skipped | |
| 🟩 | SetupEnvironment(rust) |
865.8ms | Passed | |
| ⬛️ | InstallDependencies(rust) |
209.6ms | Skipped | |
| 🟩 | RunTask(go-toolchain:build) |
1m 37s | Passed | |
| 🟩 | RunTask(go-toolchain:check) |
1m 48s | Passed | |
| 🟩 | RunTask(go-toolchain:lint) |
1m 49s | Passed | |
| 🟩 | RunTask(go-toolchain:test) |
1m 40s | Passed |
Environment
OS: Windows
Matrix:
os = depot-windows-2025-8
job = 0
Variables:
PROTO_LOG = trace
Changed files
.protolock
Cargo.lock
toolchains/go/Cargo.toml
toolchains/go/src/go_mod.rs
toolchains/go/src/go_work.rs
toolchains/go/tests/__fixtures__/mod-files/advanced.mod
toolchains/go/tests/__fixtures__/work-files/advanced.work
toolchains/go/tests/go_mod_test.rs
toolchains/go/tests/go_work_test.rs
Contributor
Author
|
@milesj can we roll this out as a patch release? this is currently blocking me from using the go toolchain with moonrepo |
Contributor
|
Will try today or tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Go 1.24's new
ignoredirective in bothgo.modandgo.workfiles. The main changes ensure that the parser can handle and ignore these directives