fix(moq-hls): account for audio groups in master variants - #2264
Conversation
Co-Authored-By: Codex <codex@openai.com>
There was a problem hiding this comment.
Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughHLS master playlist generation now groups audio renditions by codec, assigns codec-specific group IDs when needed, and calculates group bandwidths. Video stream entries are rendered per audio group with matching ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Codex <codex@openai.com>
Summary
BANDWIDTH.The root cause was that master rendering treated a video rendition as the complete playable HLS variant. It therefore advertised only the video bitrate and copied the first audio codec even though the referenced audio group could select other renditions.
Closes #2250.
Public API changes
moq-hls.Test plan
cargo test -p moq-hls(24 passed)cargo clippy -p moq-hls --lib -- -D warningscargo fmt --all -- --checkgit diff --check(Written by GPT-5)