build(moq-video): bump moq-vaapi to 0.0.3 (dlopen libva)#2465
Conversation
moq-vaapi 0.0.3 dlopen's libva at runtime instead of linking it, so an enabled-vaapi build no longer needs libva-dev and the binary carries no NEEDED libva: a libva-less host loads and falls back to the next encoder like the NVENC backend. Bump the dep (0.0.x requirements are exact) and correct the moq-video feature comments that still described the old hard-link behavior. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
…d-docs-5b024c # Conflicts: # Cargo.toml
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated the workspace 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@rs/moq-video/Cargo.toml`:
- Around line 31-34: Update both VAAPI comments in the feature section to
qualify the fallback behavior as applying only to automatic encoder selection.
Do not claim that explicit Hardware or Named selections fall back to another
encoder; preserve the existing feature configuration and code unchanged.
- Around line 89-91: Update the remaining VAAPI comments in vaapi.rs, flake.nix,
and moq-transcode’s Cargo.toml to reflect moq-vaapi 0.0.3’s current runtime
dlopen behavior: remove claims of link-time libva dependency and any wording
that presents dlopen as future work, while preserving accurate build and
fallback details.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f0fad2f7-7b09-4513-a5a0-78803b331aed
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
Cargo.tomlrs/moq-video/Cargo.toml
Address CodeRabbit review on #2465: - The openh264 fallback only applies to automatic backend selection (Kind::Auto); explicit Hardware/Named selection does not fall back. Say "automatic backend selection" in the moq-video feature/dep comments. - Update the sibling comments still describing moq-vaapi as link-time or dlopen-as-future-work to the shipped 0.0.3 runtime-dlopen behavior: the vaapi.rs module doc, the flake.nix libva note (now runtime-only), and moq-transcode's vaapi feature comment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What
Bump
moq-vaapifrom0.0.2to0.0.3and correct the moq-video feature comments that still described the old hard-link behavior.Why
moq-vaapi 0.0.3(moq-dev/vaapi#1) switches from linking libva at build time todlopening it at runtime (bindgen--dynamic-loading). The practical effects for this repo:vaapibuild no longer needslibva-dev/ pkg-config at build time.NEEDED libva.so.2— a libva-less host now loads and falls back to the next encoder (openh264) instead of failing at process load, exactly like the NVENC backend.moq-videodocs.rs build (docs.rs builds on Linux with nolibva-dev, which is why thevaapidefault feature failed there).0.0.xversion requirements are exact, so the bump is required to pick up0.0.3.Testing
moq-vaapi 0.0.3(identical code) was verified on an aarch64 Linux host with no libva: builds with rust + clang only, the binary has noNEEDED libva, and it falls back gracefully whether libva is absent or present-without-a-driver.cargo update -p moq-vaapi --precise 0.0.3resolves from crates.io;cargo check -p moq-videoandtaplo format --checkpass locally.Note
This does not by itself refresh the live docs.rs page for the already-published
moq-video 0.0.7— docs.rs reads dependency metadata from the published crate, so thevaapidocs go green only when a newmoq-videoversion ships carrying this bump.🤖 Generated with Claude Code
(written by Opus 4.8)