fix: complete post-merge API migrations - #3285
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: GPT-5 <noreply@openai.com>
kixelated
force-pushed
the
codex/fix-video-test-priority
branch
from
September 1, 2026 17:49
4c30dc3 to
62c26b7
Compare
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moq-videodiscontinuity testmainmerged intodevErrUnresolvableBroadcastsentinel using the current vanity module pathsThe
devmerge combined the new regression tests with older conflict resolutions in their implementations and wrappers, leaving the full-tree Check gate unable to compile or type-check.Public API changes
ErrUnresolvableBroadcastsentinel for the existing FFI error variant.MoqVideoHintfield toNone, matchingmainand the intended API.Wire behavior changes
None.
Test plan
just fixjust check-allthrough the final Go gatejust go checkafter correcting the stale test import pathsCross-package sync: Rust FFI, Python, and Go are updated together. Kotlin generation and tests passed in
check-all; Swift was skipped locally because no Swift toolchain is available.(written by GPT-5)