Skip to content

fix: complete post-merge API migrations - #3285

Merged
kixelated merged 1 commit into
devfrom
codex/fix-video-test-priority
Sep 1, 2026
Merged

fix: complete post-merge API migrations#3285
kixelated merged 1 commit into
devfrom
codex/fix-video-test-priority

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

  • pass the catalog video priority in the stale moq-video discontinuity test
  • restore UniFFI defaults for optional video hint fields that were lost when main merged into dev
  • update the Python defaults regression to the renamed PCM format and max-age fields
  • expose and test the Go ErrUnresolvableBroadcast sentinel using the current vanity module paths

The dev merge combined the new regression tests with older conflict resolutions in their implementations and wrappers, leaving the full-tree Check gate unable to compile or type-check.

Public API changes

  • Go adds the missing additive ErrUnresolvableBroadcast sentinel for the existing FFI error variant.
  • UniFFI-generated constructors once again default every optional MoqVideoHint field to None, matching main and the intended API.

Wire behavior changes

None.

Test plan

  • just fix
  • just check-all through the final Go gate
  • just go check after correcting the stale test import paths

Cross-package sync: Rust FFI, Python, and Go are updated together. Kotlin generation and tests passed in check-all; Swift was skipped locally because no Swift toolchain is available.

(written by GPT-5)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T17:52:24.395253Z 62c26b7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: GPT-5 <noreply@openai.com>
@kixelated
kixelated force-pushed the codex/fix-video-test-priority branch from 4c30dc3 to 62c26b7 Compare September 1, 2026 17:49
@kixelated
kixelated merged commit 0607792 into dev Sep 1, 2026
3 checks passed
@kixelated
kixelated deleted the codex/fix-video-test-priority branch September 1, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant