Port the native-JS client to @moq/net 0.2 + @moq/hang 0.3#23
Conversation
The published @moq/net (0.2.0) and @moq/hang (0.3.0) changed the subscribe API
out from under this client, so it hung/errored and every * -> js-native-* cell
failed. Four changes:
- announced(prefix) now yields entries whose path is RELATIVE to the prefix.
We pass the exact broadcast as the prefix, so the old
Moq.Path.hasPrefix(path, entry.path) guard was never true and the wait loop
spun forever. Any active entry under an exact prefix is our broadcast.
- Broadcast.subscribe(name, priority) became subscribe(name, options?), so the
bare priority number is now { priority }.
- @moq/hang dropped the Catalog.Consumer helper; read the Catalog.TRACK frames
directly and validate each JSON snapshot with Catalog.RootSchema.
- Group.readFrame() resolves to a Frame { payload, timestamp }, not raw bytes,
so decode/measure frame.payload.
Validated end-to-end against moq-relay + the published packages: both
`python -> js-native-node` and `python -> js-native-bun` pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Follow-up to #21/#22. The native-JS subscriber was written against
@moq/net0.1.x /@moq/hang0.2.x; the published@moq/net 0.2.0+@moq/hang 0.3.0changed the subscribe API, so it hung and every* -> js-native-node/buncell failed.Four breaking changes handled
announced(prefix)paths are now relative to the prefix. We pass the exact broadcast as the prefix, so the matching entry's path is""and the oldMoq.Path.hasPrefix(path, entry.path)guard was never true → the wait loop spun until timeout. Anyactiveentry under an exact prefix is our broadcast.Broadcast.subscribe(name, priority)→subscribe(name, options?)— the bare priority number is now{ priority }.@moq/hangdroppedCatalog.Consumer— read theCatalog.TRACK(catalog.json) frames directly and validate each JSON snapshot withCatalog.RootSchema.Group.readFrame()resolves to aFrame { payload, timestamp }, not raw bytes — decode/measureframe.payload.Validation
Ran the harness locally against
moq-relay+ the real published packages, both runtimes:(written by Opus 4.8)